94912[TASK] Use stubs for test doubles without expectations
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 307
- typo3/sysext/adminpanel/Tests/Unit/Modules/PreviewModuleTest.php+8 −8
- typo3/sysext/backend/Tests/Functional/Authentication/PasswordResetTest.php+3 −3
- typo3/sysext/backend/Tests/Functional/Backend/Bookmark/BookmarkServiceTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/Wizard/PageWizardControllerTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Controller/MfaConfigurationControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/MfaControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/MfaSetupControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/ResetPasswordControllerTest.php+9 −9
- typo3/sysext/backend/Tests/Functional/Form/Element/MfaInfoElementTest.php+3 −3
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaFlexProcessTest.php+24 −19
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaInputPlaceholdersTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Middleware/BackendModuleValidatorTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/View/Drawing/BackendLayoutRendererTest.php+3 −3
- typo3/sysext/backend/Tests/Functional/View/Event/AfterPageContentPreviewRenderedTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Backend/Bookmark/Security/BookmarkGroupVoterTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Backend/Bookmark/Security/BookmarkVoterTest.php2+2 −6
- typo3/sysext/backend/Tests/Unit/Configuration/TranslationConfigurationProviderTest.php+25 −25
- typo3/sysext/backend/Tests/Unit/Controller/ContentElement/NewContentElementControllerTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Controller/File/FileControllerTest.php+15 −15
- typo3/sysext/backend/Tests/Unit/Controller/Wizard/SuggestWizardControllerTest.php+1 −1
Show 287 more files
- typo3/sysext/backend/Tests/Unit/Controller/AbstractLinkBrowserControllerTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Controller/EditDocumentControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Controller/FormInlineAjaxControllerTest.php+12 −12
- typo3/sysext/backend/Tests/Unit/Controller/SiteConfigurationControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Controller/SiteSettingsControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Controller/SwitchUserControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/ElementBrowser/ElementBrowserParametersTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/Element/DatetimeElementTest.php+33 −33
- typo3/sysext/backend/Tests/Unit/Form/Element/JsonElementTest.php+17 −17
- typo3/sysext/backend/Tests/Unit/Form/Element/UuidElementTest.php+15 −15
- typo3/sysext/backend/Tests/Unit/Form/FieldControl/ElementBrowserTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/Form/FieldWizard/TableListTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/FlexFormSegmentTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/OrderedProviderListTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/SiteConfigurationDataGroupTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaDatabaseRecordTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaInputPlaceholderRecordTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaSelectTreeAjaxFieldDataTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseDefaultLanguagePageRowTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabasePageLanguageOverlayRowsTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseParentPageRowTest.php+7 −7
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseSystemLanguageRowsTest.php+8 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/EvaluateDisplayConditionsTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/InitializeProcessedTcaTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteDatabaseEditRowTest.php+22 −22
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteResolvingTest.php+12 −12
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessFieldDescriptionsTest.php+8 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessFieldLabelsTest.php+10 −10
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsRemoveEmptyRelationsTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFolderTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineConfigurationTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineExpandCollapseStateTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaLanguageTest.php+27 −27
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRadioItemsTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaTablePermissionTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaTextTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/UserTsConfigTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/Processor/SelectItemProcessorTest.php+11 −11
- typo3/sysext/backend/Tests/Unit/Form/FormDataCompilerTest.php+23 −23
- typo3/sysext/backend/Tests/Unit/Form/NodeFactoryTest.php+9 −9
- typo3/sysext/backend/Tests/Unit/Http/RouteDispatcherTest.php+101 −101
- typo3/sysext/backend/Tests/Unit/Module/AccessGate/AdminGateTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/Module/AccessGate/SystemMaintainerGateTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/Module/AccessGate/UserGateTest.php+7 −7
- typo3/sysext/backend/Tests/Unit/Module/ModuleAccessGateRegistryTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Module/ModuleFactoryTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Module/ModuleRegistryTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/RecordList/Event/AfterRecordListRowPreparedEventTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Routing/UriBuilderTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Security/EmailLoginNotificationTest.php+10 −10
- typo3/sysext/backend/Tests/Unit/User/SharedUserPreferencesTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/DataProviderCollectionTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Wizard/WizardProviderRegistryTest.php+7 −5
- typo3/sysext/beuser/Tests/Functional/ViewHelpers/MfaStatusViewHelperTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Cache/Backend/ApcuBackendTest.php+16 −16
- typo3/sysext/core/Tests/Functional/Cache/Backend/FileBackendTest.php+6 −6
- typo3/sysext/core/Tests/Functional/Cache/Backend/MemcachedBackendTest.php+45 −45
- typo3/sysext/core/Tests/Functional/Cache/Backend/RedisBackendTest.php+4 −4
- typo3/sysext/core/Tests/Functional/Cache/Backend/Typo3DatabaseBackendTest.php+60 −60
- typo3/sysext/core/Tests/Functional/Cache/Core/ClassAliasLoaderTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Configuration/Loader/YamlFileLoaderTest.php+16 −16
- typo3/sysext/core/Tests/Functional/Database/Query/Restriction/AbstractRestrictionTestCase.php+1 −1
- typo3/sysext/core/Tests/Functional/Database/Schema/AbstractSchemaBasedTestCase.php+6 −6
- typo3/sysext/core/Tests/Functional/Error/ProductionExceptionHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Hooks/TcaItemsProcessorFunctionsTest.php+8 −9
- typo3/sysext/core/Tests/Functional/Imaging/IconFactoryTest.php+13 −13
- typo3/sysext/core/Tests/Functional/Imaging/IconTest.php+8 −8
- typo3/sysext/core/Tests/Functional/Localization/TcaSystemLanguageCollectorTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Mail/TemplatedEmailFactoryTest.php+4 −4
- typo3/sysext/core/Tests/Functional/Package/Event/PackageInitializationEventTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Page/ImportMapTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+1 −1
- typo3/sysext/core/Tests/Functional/PasswordPolicy/Validator/NotCurrentPasswordValidatorTest.php+1 −4
- typo3/sysext/core/Tests/Functional/PasswordPolicy/PasswordPolicyValidatorTest.php+1 −4
- typo3/sysext/core/Tests/Functional/Resource/Index/FileIndexRepositoryTest.php+6 −6
- typo3/sysext/core/Tests/Functional/Resource/OnlineMedia/Processing/PreviewProcessingTest.php+6 −6
- typo3/sysext/core/Tests/Functional/Resource/Service/ExtractorServiceTest.php+18 −18
- typo3/sysext/core/Tests/Functional/Resource/Service/ResourceConsistencyServiceTest.php2+7 −10
- typo3/sysext/core/Tests/Functional/Resource/RelativeCssPathFixerTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+6 −6
- typo3/sysext/core/Tests/Functional/Resource/SynchronizeFolderRelationsTest.php+1 −2
- typo3/sysext/core/Tests/Functional/Security/ContentSecurityPolicy/Reporting/BeforePersistingReportEventTest.php8+6 −5
- typo3/sysext/core/Tests/Functional/Site/Entity/SiteTest.php+1 −1
- typo3/sysext/core/Tests/Functional/SystemResource/Publishing/DefaultResourcePublisherTest.php+2 −2
- typo3/sysext/core/Tests/Functional/SystemResource/SystemResourceFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php2+8 −8
- typo3/sysext/core/Tests/Unit/Authentication/UserSettingsFactoryTest.php+7 −7
- typo3/sysext/core/Tests/Unit/Cache/Backend/TransientMemoryBackendTest.php+10 −10
- typo3/sysext/core/Tests/Unit/Cache/Frontend/PhpFrontendTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Cache/Frontend/VariableFrontendTest.php+7 −7
- typo3/sysext/core/Tests/Unit/Command/SendEmailCommandTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Configuration/Loader/YamlFileLoaderTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+4 −5
- typo3/sysext/core/Tests/Unit/Configuration/SiteWriterTest.php+10 −10
- typo3/sysext/core/Tests/Unit/Console/CommandRegistryTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Core/ClassLoadingInformationGeneratorTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Database/Platform/PlatformInformationTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php+16 −17
- typo3/sysext/core/Tests/Unit/Database/Query/BulkInsertTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+11 −11
- typo3/sysext/core/Tests/Unit/Database/Query/QueryHelperTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Types/SetTypeTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/Schema/ConnectionMigratorTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/SqlReaderTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Database/ConnectionTest.php+3 −3
- typo3/sysext/core/Tests/Unit/DataHandling/Localization/StateTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/AbstractSoftReferenceParserTestCase.php+1 −3
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkSoftReferenceParserTest.php+4 −4
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkTagSoftReferenceParserTest.php+3 −3
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+66 −66
- typo3/sysext/core/Tests/Unit/DataHandling/SlugHelperTest.php+12 −14
- typo3/sysext/core/Tests/Unit/DependencyInjection/ConsoleCommandPassTest.php+10 −10
- typo3/sysext/core/Tests/Unit/DependencyInjection/FailsafeContainerTest.php+77 −77
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderCompilationPassTest.php+2 −2
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderRegistryTest.php+7 −7
- typo3/sysext/core/Tests/Unit/Domain/Event/ModifyDefaultConstraintsForDatabaseQueryEventTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Domain/RawRecordTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Domain/RecordFactoryTest.php+12 −12
- typo3/sysext/core/Tests/Unit/ExpressionLanguage/ResolverTest.php+15 −15
- typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Http/Security/ReferrerEnforcerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/ClientTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Http/MiddlewareStackResolverTest.php+12 −12
- typo3/sysext/core/Tests/Unit/Mail/Event/AfterMailerSentMessageEventTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Mail/Event/BeforeMailerSentMessageEventTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Messaging/Renderer/BootstrapRendererTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Middleware/CacheTagsAttributeTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Middleware/VerifyHostHeaderTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Package/Cache/PackageStatesPackageCacheTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Package/AbstractServiceProviderTest.php+13 −13
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+7 −7
- typo3/sysext/core/Tests/Unit/Package/PackageTest.php+11 −11
- typo3/sysext/core/Tests/Unit/Page/AssetRendererTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php+7 −7
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/Driver/DriverRegistryTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Resource/Filter/FileNameFilterTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Resource/Index/IndexerTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/OnlineMedia/Event/AfterVideoPreviewFetchedEventTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/OnlineMedia/Helpers/VimeoHelperTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Resource/Processing/ProcessorRegistryTest.php+10 −10
- typo3/sysext/core/Tests/Unit/Resource/Rendering/AudioTagRendererTest.php+16 −16
- typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php+19 −19
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+45 −45
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+44 −44
- typo3/sysext/core/Tests/Unit/Resource/Service/ConfigurationServiceTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Resource/TextExtraction/PlainTextExtractorTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Resource/AbstractFileTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/FileReferenceTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/FolderTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Resource/MetaDataAspectTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/StorageRepositoryTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Routing/Aspect/AspectFactoryTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Routing/PageRouterLimitToPagesTest.php+18 −18
- typo3/sysext/core/Tests/Unit/Routing/PageRouterTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Routing/SiteMatcherTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Schema/TcaSchemaFactoryTest.php+13 −13
- typo3/sysext/core/Tests/Unit/Security/ContentSecurityPolicy/Configuration/CspConfigurationFactoryTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Security/ContentSecurityPolicy/Event/BeforePersistingReportEventTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Service/MarkerBasedTemplateServiceTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Session/Backend/DatabaseSessionBackendTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Session/SessionManagerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Session/UserSessionManagerTest.php+14 −14
- typo3/sysext/core/Tests/Unit/SystemResource/Identifier/SystemResourceIdentifierFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/TreeDataProviderFactoryTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+11 −11
- typo3/sysext/core/Tests/Unit/RegistryTest.php2+6 −6
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/RepositoryTest.php+4 −4
- typo3/sysext/extbase/Tests/Functional/Service/ExtensionServiceTest.php+12 −12
- typo3/sysext/extbase/Tests/Functional/Utility/LocalizationUtilityTest.php+6 −12
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/ConjunctionValidatorTest.php+11 −27
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+14 −14
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+5 −5
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+13 −13
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+23 −23
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryFactoryTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryResultTest.php2+19 −18
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/SessionTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Typo3QuerySettingsTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/CountryConverterTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Property/PropertyMappingConfigurationTest.php+12 −12
- typo3/sysext/extbase/Tests/Unit/Service/CacheServiceTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php+3 −3
- typo3/sysext/extensionmanager/Tests/Unit/Controller/ActionControllerTest.php+4 −4
- typo3/sysext/extensionmanager/Tests/Unit/Controller/DownloadControllerTest.php+2 −2
- typo3/sysext/extensionmanager/Tests/Unit/Report/ExtensionStatusTest.php+14 −14
- typo3/sysext/extensionmanager/Tests/Unit/Service/ExtensionManagementServiceTest.php2+5 −4
- typo3/sysext/extensionmanager/Tests/Unit/Utility/DependencyUtilityTest.php+2 −2
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+14 −14
- typo3/sysext/filelist/Tests/Unit/Event/AfterFileListRowPreparedEventTest.php+9 −9
- typo3/sysext/filelist/Tests/Unit/FileListTest.php+28 −28
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/LinkViewHelperTest.php+6 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/PageRendererViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/UriViewHelperTest.php+4 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SelectViewHelperTest.php+12 −12
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/UploadDeleteCheckboxViewHelperTest.php+12 −12
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Page/FooterDataViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Page/HeaderDataViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ResourceViewHelperTest.php+3 −3
- typo3/sysext/fluid/Tests/Unit/Core/Rendering/RenderingContextTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/TypolinkViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/TypolinkViewHelperTest.php+2 −2
- typo3/sysext/form/Tests/Functional/Controller/FormEditorControllerTest.php+50 −50
- typo3/sysext/form/Tests/Functional/Controller/FormFrontendControllerTest.php+12 −12
- typo3/sysext/form/Tests/Functional/Controller/FormManagerControllerTest.php+95 −95
- typo3/sysext/form/Tests/Functional/Domain/Configuration/ConfigurationServiceTest.php+44 −44
- typo3/sysext/form/Tests/Functional/Domain/Configuration/FormDefinitionValidationServiceTest.php+10 −10
- typo3/sysext/form/Tests/Functional/Domain/Factory/ArrayFormFactoryTest.php+4 −4
- typo3/sysext/form/Tests/Functional/Domain/Finishers/EmailFinisherTest.php+5 −5
- typo3/sysext/form/Tests/Functional/Domain/Finishers/SaveToDatabaseFinisherTest.php+3 −3
- typo3/sysext/form/Tests/Functional/Domain/Model/Renderable/AbstractRenderableTest.php+4 −4
- typo3/sysext/form/Tests/Functional/Domain/Renderer/FluidFormRendererTest.php+1 −1
- typo3/sysext/form/Tests/Functional/Domain/Runtime/FormRuntimeTest.php+12 −12
- typo3/sysext/form/Tests/Functional/EventListener/DataStructureIdentifierListenerTest.php+35 −35
- typo3/sysext/form/Tests/Functional/Mvc/Configuration/ConfigurationManagerTest.php+6 −6
- typo3/sysext/form/Tests/Functional/Mvc/Property/TypeConverter/FormDefinitionArrayConverterTest.php+8 −8
- typo3/sysext/form/Tests/Functional/Mvc/Property/FileUploadMimeTypeValidatorRegistrationTest.php+1 −1
- typo3/sysext/form/Tests/Functional/Mvc/Validation/FileSizeValidatorTest.php+4 −4
- typo3/sysext/form/Tests/Functional/Mvc/Validation/MimeTypeValidatorTest.php+4 −4
- typo3/sysext/form/Tests/Functional/Service/TranslationServiceTest.php+5 −5
- typo3/sysext/form/Tests/Functional/ViewHelpers/Form/UploadedResourceViewHelperTest.php+2 −2
- typo3/sysext/form/Tests/Unit/DependencyInjection/FormYamlCollectorConfiguratorTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinition/Validators/CreatableFormElementPropertiesValidatorTest.php+9 −9
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinition/Validators/CreatablePropertyCollectionElementPropertiesValidatorTest.php+9 −9
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionConversionServiceTest.php+3 −4
- typo3/sysext/form/Tests/Unit/Domain/Factory/ArrayFormFactoryTest.php+2 −2
- typo3/sysext/form/Tests/Unit/Domain/Finishers/AbstractFinisherTest.php+36 −36
- typo3/sysext/form/Tests/Unit/Domain/Finishers/ClosureFinisherTest.php+4 −4
- typo3/sysext/form/Tests/Unit/Domain/Finishers/SaveToDatabaseFinisherTest.php+5 −5
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractFormElementTest.php+2 −2
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/FormElements/FileUploadTest.php+2 −2
- typo3/sysext/form/Tests/Unit/EventListener/FormatDateRenderableBeforeRenderingTest.php+1 −1
- typo3/sysext/form/Tests/Unit/EventListener/TranslateDefaultValueBeforeRenderingTest.php+8 −8
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/YamlSourceTest.php+5 −5
- typo3/sysext/form/Tests/Unit/Mvc/ProcessingRuleTest.php+5 −5
- typo3/sysext/form/Tests/Unit/Service/CleanupFormUploadsServiceTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Service/FormEditorEnrichmentServiceTest.php+8 −8
- typo3/sysext/form/Tests/Unit/Service/RichTextConfigurationServiceTest.php+59 −59
- typo3/sysext/frontend/Tests/Functional/ContentObject/CaseContentObjectTest.php+3 −3
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+7 −7
- typo3/sysext/frontend/Tests/Functional/Processor/GalleryProcessorTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Event/AfterContentObjectRendererInitializedEventTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/Event/AfterGetDataResolvedEventTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Event/BeforeStdWrapContentStoredInCacheEventTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Event/EnhanceStdWrapEventTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Event/ModifyImageSourceCollectionEventTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+5 −6
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentDataProcessorTest.php+5 −5
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest.php+9 −9
- typo3/sysext/frontend/Tests/Unit/Typolink/DatabaseRecordLinkBuilderTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Typolink/ExternalUrlLinkBuilderTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Typolink/PageLinkBuilderTest.php+2 −2
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+1 −1
- typo3/sysext/indexed_search/Tests/Functional/Controller/SearchControllerTest.php+13 −13
- typo3/sysext/install/Tests/Functional/Service/Typo3tempFileServiceTest.php+4 −4
- typo3/sysext/install/Tests/Unit/Controller/UpgradeControllerTest.php4+8 −8
- typo3/sysext/install/Tests/Unit/FolderStructure/AbstractNodeTest.php+1 −1
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php+6 −6
- typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php+10 −10
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php+4 −4
- typo3/sysext/install/Tests/Unit/FolderStructure/RootNodeTest.php+1 −1
- typo3/sysext/install/Tests/Unit/SystemEnvironment/DatabaseCheck/Platform/MySqlTest.php+1 −1
- typo3/sysext/lowlevel/Tests/Functional/Controller/QuerySearchControllerTest.php+5 −5
- typo3/sysext/redirects/Tests/Unit/Event/AfterAutoCreateRedirectHasBeenPersistedEventTest.php+2 −2
- typo3/sysext/redirects/Tests/Unit/Event/ModifyAutoCreateRedirectRecordBeforePersistingEventTest.php+4 −4
- typo3/sysext/redirects/Tests/Unit/Event/ModifyRedirectManagementControllerViewDataEventTest.php+2 −2
- typo3/sysext/redirects/Tests/Unit/Event/SlugRedirectChangeItemCreatedEventTest.php+6 −6
- typo3/sysext/redirects/Tests/Unit/RedirectUpdate/RedirectSourceCollectionTest.php+4 −4
- typo3/sysext/redirects/Tests/Unit/RedirectUpdate/SlugRedirectChangeItemTest.php+2 −2
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+30 −30
- typo3/sysext/rte_ckeditor/Tests/Functional/Form/Element/RichTextElementTest.php+3 −3
- typo3/sysext/scheduler/Tests/Unit/Task/TaskSerializerTest.php+5 −5
- typo3/sysext/workspaces/Tests/Unit/EventListener/WorkspaceDependencyReferenceListenerTest.php+1 −1
Review log 1723
-
Wouter Wolters uploaded patch set 1 07/23/26, 18:33
-
core-ci voted on patch set 1 V +1 07/23/26, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105265
-
Wouter Wolters uploaded patch set 2
V +107/23/26, 18:43 -
Wouter Wolters marked it ready for review 07/23/26, 18:44
-
core-ci voted on patch set 2 V +1 07/23/26, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105266
-
Oliver Klee voted on patch set 2 V +1 07/23/26, 20:07
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 07/23/26, 21:19
-
Stefan Bürk commented on patch set 2 CR -1 07/23/26, 23:18
ResourceConsistencyServiceTest.php:111```suggestion private function createStubbedStorage(int $uid): ResourceStorage&Stub ``` Method does not create a mock anymore, but a stub. Let's align the method name (also the caller within this test case !!!!)BeforePersistingReportEventTest.php:190```suggestion private function createFeaturesStub(): Features&Stub ``` Not a mock object anymore. Do we not need the stub union type here like in one of the previous changes ?BeforePersistingReportEventTest.php:192```suggestion $featuresStub = self::createStub(Features::class); ```BeforePersistingReportEventTest.php:193```suggestion $featuresStub->method('isFeatureEnabled')->willReturn(true); ```BeforePersistingReportEventTest.php:194```suggestion return $featuresStub; ```BackendUserAuthenticationTest.php:68not a mock anymore - I'll stop mentioning that, but not alligning these kind of things is possible missleading; but I get the point that that would explode the change which is already quite heavy :( - not sure how to proceede here and all the similar cases (also with helper methods having mock in it but changed to create a stub)RegistryTest.php:31Should be imported (`use` ) like the removed one for `MockObject`QueryResultTest.php:33Simplyfy FQCD (`use ...`) ...ExtensionManagementServiceTest.php:42`use ....` importUpgradeControllerTest.php:64Why not making this a stub here ?UpgradeControllerTest.php:103Why not making this a stub here ? -
Benni Mack uploaded patch set 3
CR +1V +107/24/26, 15:24 -
Benni Mack uploaded patch set 4 07/24/26, 15:32
-
core-ci voted on patch set 3 V -1 07/24/26, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105340
-
core-ci voted on patch set 4 V -1 07/24/26, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105341
-
Benni Mack uploaded patch set 5
V -107/24/26, 15:59 -
core-ci voted on patch set 5 V +1 07/24/26, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105345
-
Oliver Klee voted on patch set 5 V +1 07/24/26, 16:07
-
Stefan Bürk commented on patch set 5 CR +1 V +1 07/24/26, 16:15
BookmarkVoterTest.php:39ReplyDoneResourceConsistencyServiceTest.php:111ReplyDoneBeforePersistingReportEventTest.php:190ReplyDoneBeforePersistingReportEventTest.php:192ReplyDoneBeforePersistingReportEventTest.php:193ReplyDoneBeforePersistingReportEventTest.php:194ReplyDoneBackendUserAuthenticationTest.php:68ReplyDone -
Wouter Wolters uploaded patch set 6
CR +1V +107/24/26, 19:22 -
core-ci voted on patch set 6 V +1 07/24/26, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105351
-
Wouter Wolters commented on patch set 6 07/24/26, 20:32
RegistryTest.php:31ReplyDoneQueryResultTest.php:33ReplyDoneExtensionManagementServiceTest.php:42ReplyDoneUpgradeControllerTest.php:64ReplyDoneUpgradeControllerTest.php:103ReplyDone -
Oliver Klee voted on patch set 6 V +1 07/24/26, 20:40
-
Simon Schaufelberger voted on patch set 6 CR +1 V +1 07/24/26, 21:04
-
Stefan Bürk voted on patch set 6 CR +2 V +2 07/24/26, 21:34
-
Stefan Bürk merged patch set 7 07/24/26, 21:34
BookmarkVoterTest.php:39