Review main Merged

94924[TASK] Skip redundant npm ci in lint suites

Stefan Bürk CR +2 V +2 Easy +3 −3 updated 08/05/26, 08:30

Commit message

The pre-merge "grunt scss ts html" job runs checkGruntClean,
lintScss, lintTypescript and lintHtml sequentially. Each lint suite
started with "npm ci", which by design wipes and reinstalls
Build/node_modules from scratch. As Build/node_modules lives on the
bind-mounted core root and thus persists between the sequential
container runs of one job, three of the four installs were pure
overhead.

Guard the "npm ci" of lintScss, lintTypescript and lintHtml so it
only runs when Build/node_modules is not already provisioned,
following the pattern already used by the playwright suites.
checkGruntClean runs first and deliberately keeps its unconditional
"npm ci" to guarantee a pristine, lockfile-exact toolchain before
verifying "grunt build" produces no diff; the guarded suites then
reuse that install. Standalone invocations still provision
node_modules on first use.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 913

  1. Stefan Bürk uploaded patch set 1 07/24/26, 13:14

  2. Stefan Bürk wrote 07/24/26, 13:22

    Topic set to core-ci
  3. core-ci voted on patch set 1 V +1 07/24/26, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105313

  4. Stefan Bürk rebased onto patch set 2 V +1 08/01/26, 13:47

  5. core-ci voted on patch set 2 V +1 08/01/26, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105799

  6. core-ci commented on patch set 2 08/01/26, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105802

  7. Stefan Bürk uploaded patch set 3 08/01/26, 16:25

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  8. core-ci voted on patch set 3 V +1 08/01/26, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105806

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 08/02/26, 08:49

  10. Oliver Klee voted on patch set 3 CR +1 V +1 08/02/26, 08:50

  11. Wouter Wolters voted on patch set 3 CR +1 V +1 08/04/26, 19:44

  12. Georg Ringer voted on patch set 3 CR +2 V +2 08/05/26, 08:30

  13. Georg Ringer merged patch set 4 08/05/26, 08:30