Review main Merged

94929[TASK] Deprecate DataHandler->setCorrelationId()

Benni Mack CR +2 V +2 Normal +72 −0 updated 07/24/26, 18:57

Commit message

Since DataHandler->start() accepts an optional CorrelationId as fifth
argument, which is also handed over to internally spawned sub instances
of the DataHandler, the setter DataHandler->setCorrelationId() is
superseded: it could only be called after start() and did not propagate
the correlation id to sub instances.

The remaining call sites in EXT:redirects' SlugService now hand the
correlation id over to start() instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Benni Mack uploaded patch set 1 07/24/26, 14:15

  2. Benni Mack commented on patch set 2 07/24/26, 14:25

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 07/24/26, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105326

  4. core-ci voted on patch set 2 V +1 07/24/26, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105328

  5. Benni Mack marked it ready for review 07/24/26, 15:21

  6. Stefan Bürk uploaded patch set 3 V +1 07/24/26, 16:59

  7. core-ci voted on patch set 3 V +1 07/24/26, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105348

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 07/24/26, 17:08

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 07/24/26, 18:09

  10. Benni Mack voted on patch set 3 CR +2 V +2 07/24/26, 18:57

  11. Benni Mack merged patch set 4 07/24/26, 18:57