94930[!!!][FEATURE] Register text extractors as tagged services
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Stefan Bürk +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Stefan Bürk +1
- Maike Kiebele +1
- core-ci +1 CI
Issues 1
Files 19
- typo3/sysext/core/Classes/Attribute/AsTextExtractor.phpnew+40 −0
- typo3/sysext/core/Classes/DependencyInjection/TextExtractorPass.php4new+49 −0
- typo3/sysext/core/Classes/Resource/TextExtraction/PlainTextExtractor.php+7 −13
- typo3/sysext/core/Classes/Resource/TextExtraction/TextExtractorInterface.php+8 −11
- typo3/sysext/core/Classes/Resource/TextExtraction/TextExtractorRegistry.php5+23 −46
- typo3/sysext/core/Configuration/Services.php+9 −0
- typo3/sysext/core/Configuration/Services.yaml4+4 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-110286-TextExtractorRegistrationAndInterfaceChanged.rstnew+104 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-110286-RegisterTextExtractorsAsTaggedServices.rstnew+86 −0
- typo3/sysext/core/Tests/Functional/DependencyInjection/AsTextExtractorAttributeTest.phpnew+55 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_text_extractor/Classes/TextExtraction/HighPriorityPlainTextExtractor.phpnew+36 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_text_extractor/Classes/TextExtraction/MarkdownTextExtractor.phpnew+36 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_text_extractor/Configuration/Services.yamlnew+8 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_text_extractor/composer.jsonnew+23 −0
- typo3/sysext/core/Tests/Unit/DependencyInjection/TextExtractorPassTest.phpnew+56 −0
- typo3/sysext/core/Tests/Unit/Resource/TextExtraction/TextExtractorRegistryTest.php+19 −45
- typo3/sysext/core/ext_localconf.php+0 −6
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+14 −0
- composer.json+1 −0
Review log 1723
-
Benni Mack uploaded patch set 1 07/24/26, 14:43
-
core-ci voted on patch set 1 V +1 07/24/26, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105331
-
Benni Mack uploaded patch set 2
V +107/24/26, 19:10 -
Benni Mack marked it ready for review 07/24/26, 19:10
-
core-ci voted on patch set 2 V +1 07/24/26, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105350
-
Stefan Bürk commented on patch set 2 07/25/26, 14:09
Nice to see this movement going on. Thanks ❤️. Only some minor things.TextExtractorPass.php:29```suggestion final readonly class TextExtractorPass implements CompilerPassInterface ```TextExtractorPass.php:31```suggestion public function __construct(private string $tagName) {} ```TextExtractorRegistry.php:30Would it be possible to drop the `SingletonInterface` directly as we are already changing the whole class ? ```suggestion #[Autowire(public: true) class TextExtractorRegistry ```TextExtractorRegistry.php:42```suggestion public function __construct( #[TaggedIterator('fal.text_extractor')] protected readonly iterable $textExtractors = [], ) {} ``` Let's use PHP attribute here over `Services.yaml` usage.Services.yaml:30Can we start using `phpattributes` over `Services.yaml` for new stuff and doing this tagget iterator on the registry construtor class ? (Removing it here again). I'll comment it also for the constructor. -
Benni Mack commented on patch set 3
V +107/27/26, 14:50Published edit on patch set 2. -
Benni Mack commented on patch set 4 07/27/26, 14:51
Published edit on patch set 3. -
Benni Mack commented on patch set 4 07/27/26, 14:51
TextExtractorPass.php:29ReplyFix applied.TextExtractorPass.php:31ReplyFix applied.TextExtractorRegistry.php:30ReplyFix applied.TextExtractorRegistry.php:30ReplyFix applied.TextExtractorRegistry.php:42ReplyFix applied.Services.yaml:30ReplyDone -
core-ci voted on patch set 4 V -1 07/27/26, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105471
-
core-ci voted on patch set 3 V -1 07/27/26, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105470
-
Benni Mack uploaded patch set 5
V -107/27/26, 16:32 -
core-ci voted on patch set 5 V +1 07/27/26, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105488
-
Benni Mack marked it ready for review 07/27/26, 19:17
-
Benni Mack commented on patch set 5 07/27/26, 19:18
Services.yaml:30ReplyId first like to migrate all parts, and then centralize all of them once / separately. -
Benni Mack rebased onto patch set 6
V +107/31/26, 08:25 -
core-ci voted on patch set 6 V +1 07/31/26, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105745
-
Stefan Bürk voted on patch set 6 CR +1 V +1 08/01/26, 09:56
-
Stefan Bürk commented on patch set 6 08/01/26, 09:56
Services.yaml:30ReplyAck. -
Maike Kiebele voted on patch set 6 V +1 08/03/26, 06:45
-
Oliver Klee voted on patch set 6 V +1 08/03/26, 09:20
-
Georg Ringer voted on patch set 6 CR +2 V +2 08/05/26, 08:33
-
Georg Ringer merged patch set 7 08/05/26, 08:33