94933[!!!][FEATURE] Register meta tag managers as tagged services
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Andreas Wolf +1
-
Verified V +2 Done
- Stefan Bürk +2
- Andreas Wolf +1
- core-ci +1 CI
Issues 1
Files 23
- typo3/sysext/core/Classes/Attribute/AsMetaTagManager.phpnew+42 −0
- typo3/sysext/core/Classes/DependencyInjection/MetaTagManagerPass.phpnew+82 −0
- typo3/sysext/core/Classes/MetaTag/AbstractMetaTagManager.php+3 −3
- typo3/sysext/core/Classes/MetaTag/EdgeMetaTagManager.php+3 −0
- typo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php+5 −3
- typo3/sysext/core/Classes/MetaTag/Html5MetaTagManager.php+3 −0
- typo3/sysext/core/Classes/MetaTag/MetaTagManagerInterface.php+3 −3
- typo3/sysext/core/Classes/MetaTag/MetaTagManagerRegistry.php2+34 −61
- typo3/sysext/core/Configuration/Services.php+13 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-110287-MetaTagManagerRegistrationAndInterfaceChanged.rstnew+83 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-110287-RegisterMetaTagManagersAsTaggedServices.rstnew+84 −0
- typo3/sysext/core/Tests/Functional/DependencyInjection/AsMetaTagManagerAttributeTest.phpnew+50 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta_tag_manager/Classes/MetaTag/FixtureMetaTagManager.phpnew+29 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta_tag_manager/Configuration/Services.yamlnew+8 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_meta_tag_manager/composer.jsonnew+23 −0
- typo3/sysext/core/Tests/Unit/DependencyInjection/MetaTagManagerPassTest.php2new+87 −0
- typo3/sysext/core/Tests/Unit/MetaTag/MetaTagManagerRegistryTest.php+34 −178
- typo3/sysext/core/ext_localconf.php+0 −14
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+14 −0
- typo3/sysext/seo/Classes/MetaTag/OpenGraphMetaTagManager.php+2 −0
Review log 1013
-
Benni Mack uploaded patch set 1 07/24/26, 15:37
-
core-ci voted on patch set 1 V -1 07/24/26, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105343
-
Benni Mack uploaded patch set 2
V -108/06/26, 19:50 -
Benni Mack marked it ready for review 08/06/26, 19:50
-
core-ci voted on patch set 2 V -1 08/06/26, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106038
-
Andreas Wolf commented on patch set 2 CR +1 08/06/26, 20:38
Only two minor things, code looks fine apart from that.MetaTagManagerRegistry.php:107```suggestion $instances[$manager::class] = $manager; ```MetaTagManagerPassTest.php:52Should this probably be moved one line up to validate that the "after" is actually respected by the ordering process? -
Benni Mack uploaded patch set 3
CR +1V -108/12/26, 11:14 -
Benni Mack commented on patch set 3 08/12/26, 11:14
MetaTagManagerRegistry.php:107ReplyDoneMetaTagManagerPassTest.php:52ReplyDone -
core-ci voted on patch set 3 V +1 08/12/26, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106508
-
Stefan Bürk voted on patch set 3 CR +1 V +1 08/13/26, 18:27
-
Andreas Wolf voted on patch set 3 CR +1 V +1 08/13/26, 18:40
-
Stefan Bürk voted on patch set 3 CR +2 V +2 08/13/26, 18:41
-
Stefan Bürk merged patch set 4 08/13/26, 18:41