Review main Merged

94936[TASK] Streamline code for PHP 8.5

Wouter Wolters CR +2 V +2 Easy +17 −29 updated 07/25/26, 12:33

Commit message

* Use array_first() and array_last() for first and last values.
  Keep array_key_first() where the key itself is modified.

* Give TreeNodeCollection::asort() the literal true return type.
  Remove its obsolete ReturnTypeWillChange compatibility attribute.

* Catch DateMalformedStringException directly in DateTimeFactory.

* Mark the lazy reaction example as a readonly class.

* Update the remaining PHP 8.3 test runner example to PHP 8.5.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 69

  1. Wouter Wolters uploaded patch set 1 07/24/26, 19:49

  2. Wouter Wolters updated the commit message in patch set 2 07/24/26, 19:50

  3. core-ci voted on patch set 1 V -1 07/24/26, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105352

  4. core-ci voted on patch set 2 V -1 07/24/26, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105353

  5. Wouter Wolters uploaded patch set 3 V -1 07/24/26, 20:05

  6. core-ci voted on patch set 3 V +1 07/24/26, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105354

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 07/25/26, 08:51

  8. Benni Mack voted on patch set 3 CR +2 V +2 07/25/26, 12:33

  9. Benni Mack merged patch set 4 07/25/26, 12:33