Review main Merged

94938[BUGFIX] Avoid removed getter in dependency check

Stefan Bürk CR +2 V +2 Normal +121 −1 updated 07/25/26, 08:44

Commit message

The `Extension` model of EXT:extensionmanager lost all its
getters when table `tx_extensionmanager_domain_model_extension`
has been freed from TCA and Extbase, exposing the data as
public properties since then. One call site has not been
migrated along: `DownloadController::checkDependenciesAction()`
still calls `Extension::getVersion()` while building the list
of dependencies which need to be fetched from the remote (TER)
before the extension itself can be installed.

Clicking "Import and Install" in the Extension Manager for a
TER extension with at least one unresolved extension
dependency therefore ends in a fatal error:

  Call to undefined method TYPO3\CMS\Extensionmanager\
  Domain\Model\Extension::getVersion()

`\Error` is not covered by the surrounding `catch (\Exception)`
in that action, so the whole request dies instead of rendering
the dependency resolve dialog.

The call now reads the public `version` property. A functional
test for the dependency check action is added, covering the
rendered download queue.

Note that neither the `PackageIdentifier` rework of this
controller nor its revert are involved here. Both left this
line untouched, it reads `getVersion()` unchanged since the
getter has been dropped, which is why all branches carrying
that removal are affected.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 3

Review log 912

  1. Stefan Bürk uploaded patch set 1 07/24/26, 20:25

  2. core-ci voted on patch set 1 V +1 07/24/26, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105356

  3. Wouter Wolters voted on patch set 1 CR +1 07/24/26, 20:35

  4. Stefan Bürk updated the commit message in patch set 2 CR +1 V +1 07/24/26, 20:37

  5. core-ci voted on patch set 2 V +1 07/24/26, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105357

  6. Stefan Bürk rebased onto patch set 3 V +1 07/24/26, 22:00

  7. core-ci voted on patch set 3 V +1 07/24/26, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105360

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 07/25/26, 07:02

  9. Benni Mack voted on patch set 3 CR +1 V +1 07/25/26, 07:09

  10. Oliver Klee voted on patch set 3 V +1 07/25/26, 07:59

  11. Stefan Bürk voted on patch set 3 CR +2 V +2 07/25/26, 08:23

  12. Stefan Bürk merged patch set 4 07/25/26, 08:44