Review main Ready for review Stale

94940[BUGFIX] Resolve dependencies on replaced extensions

Stefan Bürk CR 0 V +1 Normal +181 −3 updated 08/06/26, 20:10

Commit message

A system extension removed from the core is merged into another
system extension, which declares the removed package as composer
replacement. `EXT:setup` has been removed with v14 and is
replaced by `EXT:backend`.

`PackageManager` builds its alias map from those replacements,
but keyed by composer name, and resolves it through
`getPackageKeyFromComposerName()` only. Extension constraints and
the dependency data of the extension list are extension keys, so
the removed key is never resolved:

  isLoaded('setup')                                 false
  getPackageKeyFromComposerName('setup')            'setup'
  getPackageKeyFromComposerName('typo3/cms-setup')  'backend'

Extension releases built for older core versions still depend on
the removed extension key. `DependencyUtility` therefore treats
it as neither loaded nor available and tries to fetch it from the
remote, which ends in a dependency error:

  The extension setup is not available from TER.

In the Extension Manager of a classic installation such an
extension can be downloaded, but not activated - the activation
button stays disabled. Composer mode is unaffected, as composer
resolves the replacement itself.

`PackageManager::getPackageKeyProvidingExtensionKey()` is added
to resolve an extension key to the active package providing it,
and the dependency check now resolves the loaded state, the
loaded version and the package lookup through it. Keys of
packages which simply exist are returned unchanged, so only
dependencies which are currently unresolvable are affected.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/40/94940/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/40/94940/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V +1 Needs a vote
    • Oliver Klee +1
    • core-ci +1 CI

Relation chain 3

  1. 94940 [BUGFIX] Resolve dependencies on replaced extensions This change

  2. main 94474[BUGFIX] Isolate update check from download queue This change is based on it Merged Stefan Bürk CR +2 V +2 → 14.3, 13.4 Hard +420 −1

    The chain has patch set 5 of 6, the changes above it need a rebase.

  3. main 94939[BUGFIX] Handle unknown extension list records This change is based on it Merged Stefan Bürk CR +2 V +2 → 14.3 Normal +143 −5

    The chain has patch set 3 of 4, the changes above it need a rebase.

Issues 2

Files 4

Review log 46

  1. Stefan Bürk uploaded patch set 1 07/24/26, 22:22

  2. core-ci voted on patch set 1 V +1 07/24/26, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105363

  3. Stefan Bürk rebased onto patch set 2 V +1 07/26/26, 10:07

  4. core-ci voted on patch set 2 V +1 07/26/26, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105418

  5. Oliver Klee voted on patch set 2 V +1 07/26/26, 12:30

  6. Andreas Wolf commented on patch set 2 08/06/26, 20:10

    PackageManager.php:578 Unresolved

    If we end up here, this would mean the extension key is not provided by any package, right? IMO it's wrong to return the extension key then, as that would imply that the extension *is* installed.