94948[TASK] Introduce typed DTO for form persistenceManager configuration
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/form/Classes/Controller/FormEditorController.php+2 −1
- typo3/sysext/form/Classes/Domain/Configuration/PersistenceConfigurationService.php+10 −14
- typo3/sysext/form/Classes/Domain/DTO/PersistenceManagerConfiguration.php3new+81 −0
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+4 −2
- typo3/sysext/form/Classes/Upgrades/FileFormsToDatabaseUpgradeWizard.php+1 −1
Review log 67
-
Josua Vogel uploaded patch set 1 07/26/26, 17:45
-
core-ci voted on patch set 1 V +1 07/26/26, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105428
-
Garvin Hicking commented on patch set 1 07/26/26, 19:08
Nice idea!PersistenceManagerConfiguration.php:52Lets make this `null | array` and initialize the empty array in this method here. That would make the consuming code calls a bit more lightweight, what do you think? -
Josua Vogel commented on patch set 1 07/27/26, 05:32
PersistenceManagerConfiguration.php:52ReplyI think we would get an "Undefined array key" warning if we remove the null guard from the caller. I can change it to $formSettings['persistenceManager'] ?? null, but I don't think that would be a improvement. -
Garvin Hicking commented on patch set 1 CR +1 V +1 07/27/26, 06:20
PersistenceManagerConfiguration.php:52ReplyOops. Don't mind me. ;) -
Benni Mack voted on patch set 1 CR +2 V +2 07/27/26, 13:56
-
Benni Mack merged patch set 2 07/27/26, 13:56