Review 14.3 Merged

94954[BUGFIX] Handle unknown extension list records

Stefan Bürk CR +2 V +2 Normal +143 −5 updated 07/27/26, 13:07

Commit message

Freeing table `tx_extensionmanager_domain_model_extension`
from TCA replaced the Extbase mapped `Extension` argument of
several Extension Manager actions by a plain integer uid,
which is resolved through `ExtensionRepository::findByUid()`.
That method is declared nullable, but none of the call sites
handles a missing record:

* `DownloadController::checkDependenciesAction()`
* `DownloadController::installFromTerAction()`
* `DownloadController::checkDistributionDependenciesAction()`
* `DownloadController::installDistributionAction()`
* `DistributionController::showAction()`

These records are not stable. `BulkExtensionRepositoryWriter`
drops all records of a remote on import and bulk inserts the
parsed list again, so every extension list update assigns new
identifiers. A view rendered before such an update carries
uids which do not resolve anymore, and the actions then run
into a `TypeError` or a null property access. Both are
`\Error` and thus not covered by the surrounding
`catch (\Exception)`, ending in a fatal error.

`ExtensionRepository::getByUid()` is added as the throwing
counterpart of `findByUid()`, raising the new
`ExtensionNotFoundException` with a message pointing to the
outdated extension list. The affected actions use it now,
turning the fatal error into a controlled and speaking one.

Functional tests for the repository method and for the
dependency check action are added.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 3

Files 6

Review log 34

  1. Stefan Bürk commented on patch set 1 07/27/26, 12:56

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/27/26, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105464

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 07/27/26, 13:07

  4. Stefan Bürk merged patch set 2 07/27/26, 13:07