94957[TASK] Introduce typed DTO for formManager configuration
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −1
- typo3/sysext/form/Classes/Controller/FormManagerController.php3+22 −24
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+3 −14
- typo3/sysext/form/Classes/Domain/Configuration/PersistenceConfigurationService.php+1 −1
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/ConfigurationValueNormalizationTrait.phpnew+78 −0
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/FormManagerConfiguration.phpnew+130 −0
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/NewFormTemplateConfiguration.phpnew+58 −0
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/PersistenceManagerConfiguration.phprenamed+3 −19
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/SelectablePrototypeConfiguration.phpnew+87 −0
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+1 −1
- typo3/sysext/form/Tests/Functional/Controller/FormManagerControllerTest.php+4 −5
Review log 1014
-
Josua Vogel uploaded patch set 1 07/27/26, 14:55
-
Josua Vogel uploaded patch set 2 07/27/26, 15:11
-
core-ci voted on patch set 1 V -1 07/27/26, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105472
-
core-ci voted on patch set 2 V -1 07/27/26, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105475
-
Josua Vogel uploaded patch set 3
V -107/27/26, 15:48 -
core-ci voted on patch set 3 V -1 07/27/26, 16:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105479
-
Josua Vogel uploaded patch set 4
V -107/27/26, 16:30 -
core-ci voted on patch set 4 V +1 07/27/26, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105487
-
Garvin Hicking commented on patch set 4 07/28/26, 10:10
-
Josua Vogel commented on patch set 4 07/28/26, 14:02
FormManagerController.php:336ReplyI don't think it should be part of the DTO, since the array is a special construct for the TranslationService. -
Josua Vogel commented on patch set 4 09/03/26, 06:00
FormManagerController.php:336ReplyAcknowledged -
Garvin Hicking voted on patch set 4 CR +1 V +1 09/03/26, 06:31
-
Georg Ringer voted on patch set 4 CR +2 V +2 09/03/26, 08:17
-
Georg Ringer merged patch set 5 09/03/26, 08:17
FormManagerController.php:336