Review main Merged

94957[TASK] Introduce typed DTO for formManager configuration

Josua Vogel CR +2 V +2 Hard +388 −65 updated 09/03/26, 08:17

Commit message

The "formManager" section of the form YAML configuration was accessed
throughout `FormManagerController` via loosely typed array lookups such
as `$formSettings['formManager']['stylesheets']` or nested `foreach`
loops over `selectablePrototypesConfiguration`. This offered no type
safety and no single source of truth for the available options.

The nested prototype configuration is modelled by dedicated sub-DTOs
`SelectablePrototypeConfiguration` and `NewFormTemplateConfiguration`,
so the previously untyped arrays are now fully typed.

Additionally, the configuration DTOs are grouped in a dedicated
`Domain\DTO\FormConfiguration` sub-namespace for better structure. The
existing `PersistenceManagerConfiguration` DTO is moved accordingly,
and its imports are adjusted in `FormEditorController`,
`PersistenceConfigurationService` and `FormPersistenceManager`.

The duplicated value normalization logic (previously present in both
`FormManagerConfiguration` and `PersistenceManagerConfiguration`) is
extracted into a shared `ConfigurationValueNormalizationTrait`.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1014

  1. Josua Vogel uploaded patch set 1 07/27/26, 14:55

  2. Josua Vogel uploaded patch set 2 07/27/26, 15:11

  3. core-ci voted on patch set 1 V -1 07/27/26, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105472

  4. core-ci voted on patch set 2 V -1 07/27/26, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105475

  5. Josua Vogel uploaded patch set 3 V -1 07/27/26, 15:48

  6. core-ci voted on patch set 3 V -1 07/27/26, 16:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105479

  7. Josua Vogel uploaded patch set 4 V -1 07/27/26, 16:30

  8. core-ci voted on patch set 4 V +1 07/27/26, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105487

  9. Garvin Hicking commented on patch set 4 07/28/26, 10:10

    FormManagerController.php:336

    How about `$formManagerConfiguration->getDetailsFor('deleteAction')`? So that the whole array struct is part of the DTO's domain.
  10. Josua Vogel commented on patch set 4 07/28/26, 14:02

    FormManagerController.php:336 Reply

    I don't think it should be part of the DTO, since the array is a special construct for the TranslationService.
  11. Josua Vogel commented on patch set 4 09/03/26, 06:00

    FormManagerController.php:336 Reply

    Acknowledged
  12. Garvin Hicking voted on patch set 4 CR +1 V +1 09/03/26, 06:31

  13. Georg Ringer voted on patch set 4 CR +2 V +2 09/03/26, 08:17

  14. Georg Ringer merged patch set 5 09/03/26, 08:17