Review main Abandoned

94958[TASK] Store remote extension list as JSON file

Benni Mack CR 0 V -1 Expert +1012 −733 updated 07/27/26, 16:13

Commit message

The extension manager kept its local mirror of the packages available
in TER in the database table tx_extensionmanager_domain_model_extension:
every update of the extension list deleted and bulk-inserted tens of
thousands of rows, the table easily grew beyond 100 MB, and every
lookup went through SQL again although the data is a plain, read-only
cache of the downloaded extensions.xml.gz file.

The downloaded list is now converted into one JSON file per remote
(var/extensionmanager/<remote>.extensions.json) by the new
RemoteExtensionListStore, which replaces BulkExtensionRepositoryWriter.
ExtensionRepository keeps its query API but serves all lookups from
this file-based store. The database table, its schema definition, the
reference index exclusion listener and the install tool "clear table"
entry are removed; the table can be dropped via the database analyzer.
An already downloaded extensions.xml.gz is converted automatically the
next time the list is accessed.

Without database rows there is no uid to address a package with, so
the identification concept of #110144 is re-applied: a package is
addressed by its package key, a concrete version and the remote it
comes from, carried by the PackageIdentifier value object and resolved
via ExtensionRepository::findOneByPackageIdentifier().

The flaw that led to the revert of that approach (#110170) is fixed at
its source: Extension::createFromExtensionArray() no longer binds the
created object to the "ter" remote. An extension object created from a
locally available extension now always carries an empty remote, and
ExtensionManagementService::downloadMainExtension() only fetches
packages that were actually resolved from a remote listing. Local
extensions - whether released to TER or not - are therefore never
overwritten by a forced download when installed via the extension
manager.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 3

Files 27

Show 7 more files

Review log 35

  1. Benni Mack uploaded patch set 1 07/27/26, 14:58

  2. Benni Mack uploaded patch set 2 07/27/26, 15:09

  3. core-ci voted on patch set 1 V -1 07/27/26, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105473

  4. core-ci voted on patch set 2 V -1 07/27/26, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105474

  5. Benni Mack abandoned the change 07/27/26, 16:13

    wont do