Review main Merged

94960[TASK] Identify remote packages by key, version and remote

Benni Mack CR +2 V +2 Hard +326 −85 updated 07/30/26, 14:18

Commit message

Whenever the extension manager wanted to download or install a
package from TER, it addressed it by the uid of its row in
tx_extensionmanager_domain_model_extension. This made the whole
download and install flow depend on a package being stored in the
local database first, which stands in the way of browsing a remote
in real-time and installing from it without importing everything
into the database beforehand.

A package is now addressed by what actually identifies it: its
package key, a concrete version and the remote it comes from. A
small PackageIdentifier value object carries this triple, and
ExtensionRepository::findOneByPackageIdentifier() resolves it. Since
the table has a unique key over exactly these three fields, this
addresses the very same record the uid did, which makes the change
behaviour neutral.

The download and distribution controllers, the download ViewHelper
and the related Fluid templates hand over the identifier instead of
the uid. Extension::getIdentifier() returns it as request arguments,
so templates can pass a package on in one go:

  arguments="{identifier: extension.identifier}"

The uid based counterparts findByUid() and getByUid() are replaced by
findOneByPackageIdentifier() and getByPackageIdentifier(). The latter
keeps the guard introduced with #110290: a package taken from a view
that was rendered before an extension list update does not resolve
anymore, and still raises a speaking ExtensionNotFoundException
instead of running into a fatal error.

Resolving still happens against the database, and the download guard
in ExtensionManagementService deliberately stays untouched, so
nothing changes for the user. The difference is that a package no
longer needs a uid to be addressed, which is the groundwork for a
remote that does not populate the database.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 4

Files 13

Review log 1316

  1. Benni Mack uploaded patch set 1 07/27/26, 15:39

  2. core-ci voted on patch set 1 V +1 07/27/26, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105477

  3. Benni Mack marked it ready for review 07/27/26, 16:05

  4. Benni Mack uploaded patch set 2 07/27/26, 16:13

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  5. core-ci voted on patch set 2 V +1 07/27/26, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105483

  6. Benni Mack marked it ready for review 07/27/26, 16:36

  7. Helmut Hummel commented on patch set 2 07/28/26, 13:40

    PackageIdentifier.php:45

    could be return get_object_vars($this)

    PackageIdentifierTypeConverter.php:32

    the ObjectConverter would be enough. however then the receiving action methods would need to be configured to allow property mapping for PackageIdentifier. I would rather configure the property mapper for required actions than adding this type converter

    PackageIdentifierTest.php:63

    that belongs to the/a ExtensionTest
  8. Helmut Hummel commented on patch set 2 07/28/26, 13:40

    I like this change. I only have a few minor remarks
  9. Benni Mack uploaded patch set 3 V +1 07/28/26, 15:06

  10. core-ci voted on patch set 3 V +1 07/28/26, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105550

  11. Benni Mack commented on patch set 3 07/28/26, 15:21

    PackageIdentifier.php:45 Reply

    Done

    PackageIdentifierTypeConverter.php:32 Reply

    Done

    PackageIdentifierTest.php:63 Reply

    Done
  12. Helmut Hummel commented on patch set 3 CR +1 07/28/26, 16:45

    looks good to me now, thanks. will test later.
  13. Stefan Bürk voted on patch set 3 CR +1 V +1 07/29/26, 14:14

  14. Georg Ringer voted on patch set 3 CR +1 V +1 07/30/26, 08:29

  15. Benni Mack voted on patch set 3 CR +2 V +2 07/30/26, 14:18

  16. Benni Mack merged patch set 4 07/30/26, 14:18