94960[TASK] Identify remote packages by key, version and remote
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Stefan Bürk +1
- Helmut Hummel +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 4
- Task #110304Identify remote packages by key, version and remote in Extension Manager to avoid DB connections
- Task #110144Identify remote packages by key, version and remote
- Bug #110170Local extensions can not be installed in classic mode if not published to TER; published Extensions are forced to be installed from TER
- Bug #110290Extension Manager fatals on outdated extension list records
Files 13
- typo3/sysext/extensionmanager/Classes/Controller/DistributionController.php+12 −2
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+28 −15
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+21 −0
- typo3/sysext/extensionmanager/Classes/Domain/Model/PackageIdentifier.php2new+60 −0
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php+31 −14
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/Distribution.fluid.html+5 −5
- typo3/sysext/extensionmanager/Resources/Private/Templates/Distribution/Show.fluid.html+2 −2
- typo3/sysext/extensionmanager/Resources/Private/Templates/Download/InstallFromTer.fluid.json+1 −1
- typo3/sysext/extensionmanager/Tests/Functional/Controller/DownloadControllerTest.php+62 −24
- typo3/sysext/extensionmanager/Tests/Functional/Domain/Repository/ExtensionRepositoryTest.php+31 −21
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/ExtensionTest.php+28 −0
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/PackageIdentifierTest.php2new+44 −0
Review log 1316
-
Benni Mack uploaded patch set 1 07/27/26, 15:39
-
core-ci voted on patch set 1 V +1 07/27/26, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105477
-
Benni Mack marked it ready for review 07/27/26, 16:05
-
Benni Mack uploaded patch set 2 07/27/26, 16:13
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 2 V +1 07/27/26, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105483
-
Benni Mack marked it ready for review 07/27/26, 16:36
-
Helmut Hummel commented on patch set 2 07/28/26, 13:40
PackageIdentifier.php:45could be return get_object_vars($this)PackageIdentifierTypeConverter.php:32the ObjectConverter would be enough. however then the receiving action methods would need to be configured to allow property mapping for PackageIdentifier. I would rather configure the property mapper for required actions than adding this type converterPackageIdentifierTest.php:63that belongs to the/a ExtensionTest -
Helmut Hummel commented on patch set 2 07/28/26, 13:40
I like this change. I only have a few minor remarks -
Benni Mack uploaded patch set 3
V +107/28/26, 15:06 -
core-ci voted on patch set 3 V +1 07/28/26, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105550
-
Benni Mack commented on patch set 3 07/28/26, 15:21
PackageIdentifier.php:45ReplyDonePackageIdentifierTypeConverter.php:32ReplyDonePackageIdentifierTest.php:63ReplyDone -
Helmut Hummel commented on patch set 3 CR +1 07/28/26, 16:45
looks good to me now, thanks. will test later. -
Stefan Bürk voted on patch set 3 CR +1 V +1 07/29/26, 14:14
-
Georg Ringer voted on patch set 3 CR +1 V +1 07/30/26, 08:29
-
Benni Mack voted on patch set 3 CR +2 V +2 07/30/26, 14:18
-
Benni Mack merged patch set 4 07/30/26, 14:18