Review main Merged

94963[TASK] Introduce typed DTOs for form prototype formEditor configuration

Josua Vogel CR +2 V +2 Hard +622 −9 updated 09/26/26, 12:58

Commit message

The "prototypes.<name>" section of the form YAML configuration was
accessed throughout `FormEditorController` via loosely typed array
lookups such as `$prototypeConfiguration['formEditor']['maximumUndoSteps']`
or `$prototypeConfiguration['formEditor']['dynamicJavaScriptModules']
['additionalViewModelModules'] ?? []`. This offered no type safety and
no single source of truth for the available options.

Unlike the top-level `formManager` and `persistenceManager` sections, a
prototype is fully extensible by third-party extensions (custom form
element types, inspector editors, dynamic modules, partials, …). The
new DTOs therefore follow an "open" design: they expose typed accessors
for the well-known core keys while keeping the untouched raw
configuration reachable as an escape hatch.

A shared `RawConfigurationTrait` provides that escape hatch via
`getRaw()`, `get('dotted.path')` and `has('dotted.path')`. Consuming
DTOs declare a promoted `array $raw` property holding the original
configuration.

The raw `$prototypeConfiguration` array is still handed over to the
remaining helper methods; these accesses are migrated once the
respective sub-trees are typed in follow-up work packages.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 913

  1. Josua Vogel uploaded patch set 1 07/27/26, 16:11

  2. Josua Vogel marked it work in progress 07/27/26, 16:15

  3. core-ci voted on patch set 1 V -1 07/27/26, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105482

  4. Josua Vogel rebased onto patch set 2 V -1 07/27/26, 16:35

  5. core-ci voted on patch set 2 V -1 07/27/26, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105489

  6. Josua Vogel updated the commit message in patch set 3 V -1 09/24/26, 15:45

  7. Josua Vogel marked it ready for review 09/24/26, 15:47

  8. core-ci voted on patch set 3 V -1 09/24/26, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109171

  9. Josua Vogel uploaded patch set 4 V -1 09/25/26, 06:48

  10. core-ci voted on patch set 4 V +1 09/25/26, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109226

  11. Garvin Hicking voted on patch set 4 CR +1 V +1 09/26/26, 09:31

  12. Benni Mack voted on patch set 4 CR +2 V +2 09/26/26, 12:58

  13. Benni Mack merged patch set 5 09/26/26, 12:58