Review main Merged

94965[BUGFIX] Allow editors to toggle visibility of file references

Benni Mack CR +2 V +2 Normal +120 −1 updated 10/05/26, 15:41

Commit message

Since the field used to disable a record is added to TCA automatically
(see #104311), it is flagged as "exclude" and therefore requires an
explicit field access permission. The "hidden" fields of the tables
"sys_file_reference" and "index_config" were not excludable before, so
editors lost the ability to hide or enable such records, as existing
backend user groups lack the newly required permission.

The "exclude" flag is removed from both fields again, which restores
the previous behaviour without the need to migrate backend user
groups.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 912

  1. Benni Mack uploaded patch set 1 07/27/26, 16:14

  2. Benni Mack marked it ready for review 07/27/26, 16:15

  3. core-ci voted on patch set 1 V -1 07/27/26, 16:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105486

  4. Garvin Hicking uploaded patch set 2 V -1 07/28/26, 07:35

    Fixture needs to match varchar 50
  5. core-ci voted on patch set 2 V +1 07/28/26, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105525

  6. Oliver Klee voted on patch set 2 V +1 07/28/26, 09:01

  7. Garvin Hicking commented on patch set 2 CR -1 07/28/26, 09:12

    I believe this also needs adoption to insert "hidden" as a default here: typo3/sysext/install/Configuration/PermissionPreset/be_groups_editor.yaml typo3/sysext/install/Configuration/PermissionPreset/be_groups_advanced_editor.yaml
  8. Benni Mack uploaded patch set 3 CR -1 V +1 10/02/26, 13:32

  9. core-ci voted on patch set 3 V +1 10/02/26, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109946

  10. Garvin Hicking commented on patch set 3 CR +1 V +1 10/02/26, 14:26

    Reply

    Outdated with new revision.
  11. Oli Bartsch voted on patch set 3 CR +2 V +2 10/05/26, 15:41

  12. Oli Bartsch merged patch set 4 10/05/26, 15:41