Review main Abandoned

94966[TASK] Resolve site set dependencies via precomputed closure

Benni Mack CR 0 V 0 Normal +109 −22 updated 10/02/26, 15:40

Commit message

SetRegistry::getSets() filtered the full list of ordered sets and walked
the dependency graph from scratch for every candidate set. hasDependency()
neither memoizes nor tracks visited nodes, so a negative answer enumerates
every walk through the graph - which is exponential in dependency depth,
and repeated for each of the two or more getSets() calls per site.

The transitive dependency closure of all ordered sets is now computed once
per request with a visited set, and getSets() resolves via hash lookups on
that closure. Results are additionally memoized per requested set names.
Ordering still stems from the ordered set list, so TypoScript and settings
precedence are unchanged. hasDependency() is kept and reimplemented as a
closure lookup, as it is protected on a non-final class.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 2

Review log 23

  1. Benni Mack uploaded patch set 1 07/27/26, 20:13

  2. core-ci voted on patch set 1 V +1 07/27/26, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105490

  3. Benni Mack abandoned the change 10/02/26, 15:40

    caching helped