Review main Merged

94968[TASK] Add AGENTS.md with repository guidelines for coding agents

Benni Mack CR +2 V +2 Hard +289 −0 updated 11/10/26, 09:23

Commit message

Coding agents have to rediscover how this repository is built, tested and
reviewed on every session. Collect that knowledge in AGENTS.md: the
runTests.sh entry points and container based test suites, the dependency
injection, middleware, event and TCA schema mechanisms that span many
files, plus the coding, testing, changelog and Gerrit conventions.

AGENTS.md is the vendor neutral filename and holds all of the content. The
tool specific entry point next to it merely imports AGENTS.md, so there is
a single source of truth. Both files are exempted from personal global
ignore rules in .gitignore, which would otherwise hide them from
git status before they are tracked.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1318

  1. Benni Mack uploaded patch set 1 07/28/26, 06:44

  2. core-ci voted on patch set 1 V +1 07/28/26, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105524

  3. Benni Mack uploaded patch set 2 V +1 08/12/26, 14:12

  4. Benni Mack marked it ready for review 08/12/26, 14:12

  5. Benni Mack updated the commit message in patch set 3 08/12/26, 14:12

  6. Georg Ringer voted on patch set 3 CR +1 V +1 08/12/26, 14:18

  7. core-ci voted on patch set 3 V +1 08/12/26, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106548

  8. core-ci voted on patch set 2 V +1 08/12/26, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106547

  9. Josua Vogel commented on patch set 3 CR +1 V +1 08/12/26, 15:04

    Love it
  10. Oliver Hader uploaded patch set 4 CR +1 V +1 08/12/26, 15:46

  11. Oliver Hader voted on patch set 4 CR +1 V +1 08/12/26, 15:47

  12. core-ci voted on patch set 4 V -1 08/12/26, 16:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106555

  13. core-ci voted on patch set 4 V +1 08/12/26, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106555

  14. Josua Vogel voted on patch set 4 CR +1 V +1 08/13/26, 05:44

  15. Georg Ringer voted on patch set 4 CR +2 V +2 08/23/26, 14:28

  16. Georg Ringer merged patch set 5 08/23/26, 14:28

  17. Garvin Hicking commented on patch set 5 08/31/26, 12:30

    Thanks for this! <3
  18. Benjamin Franzke commented on patch set 5 10/02/26, 18:48

    .gitignore:81 Unresolved

    Are you sure this is actually needed? It looks like an agent needed this in order to commit this file, instead of using `git add -f`. Once a file is staged/committed, the ignore rules do no longer apply. I think these two instructions are superfluous and should therefore be removed.