Review main Merged

94971[TASK] Use dependency injection in various DI-ready classes

Benni Mack CR +2 V +2 Normal +66 −53 updated 07/28/26, 13:40

Commit message

Several services, controllers and middlewares that already use
constructor injection still fetched other stateless services such
as ConnectionPool, SiteFinder or StorageRepository via
GeneralUtility::makeInstance() inline. Those dependencies are now
injected via the constructor as well.

RedirectCacheService now gets the "pages" cache injected directly
and is marked as public service, since it is instantiated via
GeneralUtility::makeInstance() in a DataHandler hook.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 67

  1. Benni Mack uploaded patch set 1 07/28/26, 10:40

  2. Benni Mack marked it ready for review 07/28/26, 10:40

  3. core-ci voted on patch set 1 V +1 07/28/26, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105531

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 07/28/26, 12:57

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 07/28/26, 13:39

  6. Benni Mack voted on patch set 1 CR +2 V +2 07/28/26, 13:40

  7. Benni Mack merged patch set 2 07/28/26, 13:40