Review main Merged

94972[BUGFIX] Avoid TypeError for IMAGE cObject with missing file

Stig Nørgaard Færch CR +2 V +2 Normal +62 −7 updated 07/29/26, 09:54

Commit message

When an IMAGE content object references a FAL file whose
physical file has been deleted (sys_file.missing=1),
ImageResource::getPublicUrl() returns null and cImage()
passes it to AssetCollector::addMedia(), which requires a
string. The TypeError aborts the whole page rendering.

Treat a null public URL like an unresolvable image resource
and return an empty string, as the method already does when
getImgResource() returns null. This restores the behavior
of v12 and earlier.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Stig Nørgaard Færch uploaded patch set 1 07/28/26, 12:46

  2. core-ci voted on patch set 1 V +1 07/28/26, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105538

  3. Oliver Klee voted on patch set 1 CR +1 V +1 07/28/26, 14:05

  4. Benni Mack uploaded patch set 2 CR +1 V +1 07/28/26, 14:59

  5. Oliver Klee voted on patch set 2 CR +1 V +1 07/28/26, 15:01

  6. core-ci voted on patch set 2 V +1 07/28/26, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105549

  7. Garvin Hicking voted on patch set 2 CR +1 V +1 07/28/26, 15:12

  8. Garvin Hicking commented on patch set 2 CR +2 V +2 07/29/26, 09:53

    Please note, the v13 backport will need more love that I'll have to spend at a later time
  9. Garvin Hicking merged patch set 3 07/29/26, 09:54