Review main Merged

94973[TASK] Add allowed schema names to TCA schema group field type

Benni Mack CR +2 V +2 Normal +124 −11 updated 07/30/26, 11:53

Commit message

TCA type="group" fields define their relation targets via the
"allowed" property, which consumers had to read from the raw TCA
configuration array. GroupFieldType now exposes this typed as
getAllowedSchemaNames() and allowsAllSchemata(), and the four
consumers holding a field type object are adapted.

Note that RelationHandler and DataHandler previously read
"allowed" regardless of the field type, which is wrong for
type="file" fields, where "allowed" holds file extensions.
Both now check for GroupFieldType. Additionally, schema names
are trimmed and empty entries are dropped, which was not the
case in the previous manual explode() calls.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 79

  1. Benni Mack uploaded patch set 1 07/28/26, 14:01

  2. Benni Mack updated the commit message in patch set 2 07/28/26, 14:02

  3. core-ci voted on patch set 1 V +1 07/28/26, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105540

  4. core-ci voted on patch set 2 V +1 07/28/26, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105541

  5. Benni Mack marked it ready for review 07/28/26, 15:03

  6. Josua Vogel voted on patch set 2 CR +1 V +1 07/30/26, 05:40

  7. Georg Ringer voted on patch set 2 CR +1 V +1 07/30/26, 08:26

  8. Benni Mack voted on patch set 2 CR +2 V +2 07/30/26, 11:53

  9. Benni Mack merged patch set 3 07/30/26, 11:53