Review main Merged

94980[BUGFIX] Allow command "mailer:spool:send" to be schedulable again

Markus Klein CR +2 V +2 Easy +0 −2 updated 07/29/26, 13:32

Commit message

This command was schedulable before #107151

(Only the alias was not.)

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Johannes Kasberger +1
    • Lina Wolf +1
    • Sebastian Iffland +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Johannes Kasberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1317

  1. Markus Klein uploaded patch set 1 07/29/26, 09:16

  2. Markus Klein updated the commit message in patch set 2 07/29/26, 09:17

  3. core-ci voted on patch set 1 V -1 07/29/26, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105575

  4. core-ci voted on patch set 2 V -1 07/29/26, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105576

  5. Lina Wolf commented on patch set 2 CR +1 07/29/26, 09:36

  6. Lina Wolf commented on patch set 3 CR +1 V -1 07/29/26, 09:37

    Published edit on patch set 2.
  7. Lina Wolf voted on patch set 3 CR +1 07/29/26, 09:37

  8. core-ci voted on patch set 3 V +1 07/29/26, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105578

  9. Garvin Hicking commented on patch set 3 07/29/26, 09:44

    Reply

    Ah I see what happened. The old block was this: ``` TYPO3\CMS\Core\Command\SendEmailCommand: tags: - name: 'console.command' command: 'mailer:spool:send' description: 'Sends emails from the spool' - name: 'console.command' command: 'swiftmailer:spool:send' alias: true schedulable: false ``` so the "alias" was not schedulable, only the "actual" one, and when I moved the section I figured "schedulable" would apply to both. Did anyone check if with this patch both commands may appear, or only the non-aliases? Sorry for introducing this bug, that is on me.
  10. Garvin Hicking updated the commit message in patch set 4 CR +1 V +1 07/29/26, 09:46

  11. Lina Wolf voted on patch set 4 CR +1 07/29/26, 09:50

  12. core-ci voted on patch set 4 V +1 07/29/26, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105580

  13. Sebastian Iffland voted on patch set 4 CR +1 07/29/26, 09:54

  14. Johannes Kasberger voted on patch set 4 CR +1 V +1 07/29/26, 11:17

  15. Markus Klein commented on patch set 4 07/29/26, 12:09

    Reply

    only the non-alias shows up in the wizard when creating a new task
  16. Garvin Hicking voted on patch set 4 CR +2 V +2 07/29/26, 13:13

  17. Garvin Hicking merged patch set 5 07/29/26, 13:32