Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review Quiet

94982[BUGFIX] Resolve processed file pointing to original via its storage

Riny van Tiggelen CR 0 V -1 Normal +68 −0 updated 10/01/26, 07:56

Commit message

ProcessedFile::usesOriginalFile() is true when processing did not
produce a new file, for instance when the original is already smaller
than the requested dimensions. In that state getIdentifier() returns
the identifier of the original file, while getStorage() still returns
the storage of the processing folder.

Every other accessor compensates for this: exists(), getName(),
getMimeType(), getSize(), getPublicUrl(), updateProperties() and
toArray() all delegate to the original file. Only
getForLocalProcessing() does not, so the identifier of the original
file is handed to the driver of the processing storage.

While both reside in the same storage this goes unnoticed. As soon as
sys_file_storage.processingfolder uses the cross-storage syntax, e.g.
"2:_processed_/", the receiving driver is asked for an identifier it
cannot know: a Local processing storage silently returns a path to a
non-existing file, a remote driver throws.

This became reachable from image rendering with #106518, which changed
ImageResource::createFromProcessedFile() to build the full path from
getForLocalProcessing() instead of getPublicUrl() - the latter being
one of the accessors that does compensate.

Add the missing delegation, in line with exists().

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/82/94982/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/82/94982/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Issues 2

Files 2

Review log 24

  1. Riny van Tiggelen uploaded patch set 1 07/29/26, 11:18

  2. core-ci voted on patch set 1 V +1 07/29/26, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105590

  3. Riny van Tiggelen rebased onto patch set 2 V +1 10/01/26, 07:47

  4. core-ci voted on patch set 2 V -1 10/01/26, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109759