Review main Merged Breaking

94984[!!!][TASK] Reduce Bootstrap code

Benni Mack CR +2 V +2 Hard +172 −92 updated 07/29/26, 16:21

Commit message

Bootstrap::init() is cleaned up in several ways:

The loading order is adjusted: `checkEncryptionKey()` now runs before
`ext_localconf.php` files are loaded, as the encryption key is part of
the system configuration and is used for security-relevant
functionality, so it has to be in place before any extension code is
executed. Setting it from an `ext_localconf.php` file - a discouraged,
but existing deployment pattern - does not work anymore. In addition,
`$GLOBALS['TCA']` is assigned after `TcaSchemaFactory->load()` instead
of before, so the global array and the schema information become
available at the same time and consumers can not observe a
half-initialized state.

Furthermore, `Bootstrap::baseSetup()`, `Bootstrap::createConfigurationManager()`
and `Bootstrap::populateLocalConfiguration()` are removed. All three are
marked `@internal` and are not used by TYPO3 Core anymore. `baseSetup()`
only registered the class loading information in non-Composer mode,
which `Bootstrap::init()` does itself. The two configuration related
methods consisted of a single statement each and are inlined into
`Bootstrap::init()`. Extension scanner matchers are added for the two
public methods, the existing matcher for `populateLocalConfiguration()`
is extended.

Finally, the touched bootstrap and HTTP application classes receive
missing `declare(strict_types=1)` statements and return types, `@var`
annotated properties are replaced with real type declarations and the
anonymous request handlers in `MiddlewareDispatcher` use constructor
property promotion.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 810

  1. Benni Mack uploaded patch set 1 07/29/26, 12:51

  2. core-ci voted on patch set 1 V +1 07/29/26, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105600

  3. Benni Mack marked it ready for review 07/29/26, 13:07

  4. Oliver Klee updated the commit message in patch set 2 V +1 07/29/26, 13:10

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 07/29/26, 13:20

  6. core-ci voted on patch set 2 V +1 07/29/26, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105604

  7. Wouter Wolters voted on patch set 2 CR +1 07/29/26, 13:37

  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 07/29/26, 16:20

  9. Benni Mack voted on patch set 2 CR +2 V +2 07/29/26, 16:21

  10. Benni Mack merged patch set 3 07/29/26, 16:21