Review main Merged

94985[BUGFIX] Set crdate and tstamp in SaveToDatabaseFinisher

Christian Rath-Ulrich CR +2 V +2 Normal +147 −1 updated 09/16/26, 19:43

Commit message

Add automatic population of CreatedAt and UpdatedAt fields based
on the target table TCA schema, matching DataHandler behavior:
* insert: set crdate and tstamp
* update: set tstamp only
Tables without a TCA schema remain unchanged.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1519

  1. Christian Rath-Ulrich uploaded patch set 1 07/29/26, 12:54

  2. core-ci voted on patch set 1 V +1 07/29/26, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105601

  3. Benni Mack updated the commit message in patch set 2 V +1 07/29/26, 13:07

  4. Benni Mack commented on patch set 2 07/29/26, 13:08

    SaveToDatabaseFinisher.php:338

    when would that happen? :)
  5. core-ci voted on patch set 2 V +1 07/29/26, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105602

  6. Christian Rath-Ulrich commented on patch set 2 07/30/26, 06:49

    SaveToDatabaseFinisher.php:338 Reply

    So the fallback mainly covers edge cases: unit tests without a full bootstrap code running outside the normal request bootstrap It serves mainly as a defensive measure. if its unessesery in your oppinieon i will folow your lead. For SaveToDatabaseFinisher in the frontend: it will practically always use $GLOBALS['EXEC_TIME'].
  7. Josua Vogel commented on patch set 2 07/30/26, 11:36

    SaveToDatabaseFinisher.php:309

    If someone were to set `crdate` or `tstamp` to a fixed value, it would now be overwritten, and the change would be a breaking change. I think this is a bit of a long shot, but I didn't want to leave it unmentioned.

    SaveToDatabaseFinisher.php:338

  8. Benni Mack commented on patch set 2 07/30/26, 13:05

    SaveToDatabaseFinisher.php:338 Reply

    yeah, maybe I should fix this once and for all :)
  9. Christian Rath-Ulrich uploaded patch set 3 V +1 08/08/26, 19:22

  10. Christian Rath-Ulrich commented on patch set 3 08/08/26, 19:26

    SaveToDatabaseFinisher.php:309 Reply

    @benni@typo3.org Do you have any thoughts on this? Essentially, this is indeed a breaking change if you look at it closely.

    SaveToDatabaseFinisher.php:338 Reply

    Done

    SaveToDatabaseFinisher.php:338 Reply

    Done
  11. core-ci voted on patch set 3 V +1 08/08/26, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106200

  12. Benni Mack commented on patch set 3 09/15/26, 13:00

    SaveToDatabaseFinisher.php:309 Reply

    sure, I would only set it if it wasn't set before?
  13. Benni Mack uploaded patch set 4 V +1 09/16/26, 08:19

  14. Benni Mack commented on patch set 4 CR +1 09/16/26, 08:19

    SaveToDatabaseFinisher.php:309 Reply

    Done
  15. core-ci voted on patch set 4 V +1 09/16/26, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108662

  16. Benni Mack voted on patch set 4 V +1 09/16/26, 08:42

  17. Wouter Wolters voted on patch set 4 CR +1 V +1 09/16/26, 19:25

  18. Benni Mack voted on patch set 4 CR +2 V +2 09/16/26, 19:42

  19. Benni Mack merged patch set 5 09/16/26, 19:43