94985[BUGFIX] Set crdate and tstamp in SaveToDatabaseFinisher
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Wouter Wolters +1
-
Verified V +2 Done
- Benni Mack +2
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1519
-
Christian Rath-Ulrich uploaded patch set 1 07/29/26, 12:54
-
core-ci voted on patch set 1 V +1 07/29/26, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105601
-
Benni Mack updated the commit message in patch set 2
V +107/29/26, 13:07 -
Benni Mack commented on patch set 2 07/29/26, 13:08
-
core-ci voted on patch set 2 V +1 07/29/26, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105602
-
Christian Rath-Ulrich commented on patch set 2 07/30/26, 06:49
SaveToDatabaseFinisher.php:338ReplySo the fallback mainly covers edge cases: unit tests without a full bootstrap code running outside the normal request bootstrap It serves mainly as a defensive measure. if its unessesery in your oppinieon i will folow your lead. For SaveToDatabaseFinisher in the frontend: it will practically always use $GLOBALS['EXEC_TIME']. -
Josua Vogel commented on patch set 2 07/30/26, 11:36
SaveToDatabaseFinisher.php:309If someone were to set `crdate` or `tstamp` to a fixed value, it would now be overwritten, and the change would be a breaking change. I think this is a bit of a long shot, but I didn't want to leave it unmentioned.SaveToDatabaseFinisher.php:338https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/Configuration/GlobalVariables.html mentions, that EXEC_TIME shouldnt be used anymore -
Benni Mack commented on patch set 2 07/30/26, 13:05
SaveToDatabaseFinisher.php:338Replyyeah, maybe I should fix this once and for all :) -
Christian Rath-Ulrich uploaded patch set 3
V +108/08/26, 19:22 -
Christian Rath-Ulrich commented on patch set 3 08/08/26, 19:26
SaveToDatabaseFinisher.php:309Reply@benni@typo3.org Do you have any thoughts on this? Essentially, this is indeed a breaking change if you look at it closely.SaveToDatabaseFinisher.php:338ReplyDoneSaveToDatabaseFinisher.php:338ReplyDone -
core-ci voted on patch set 3 V +1 08/08/26, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106200
-
Benni Mack commented on patch set 3 09/15/26, 13:00
SaveToDatabaseFinisher.php:309Replysure, I would only set it if it wasn't set before? -
Benni Mack uploaded patch set 4
V +109/16/26, 08:19 -
Benni Mack commented on patch set 4 CR +1 09/16/26, 08:19
SaveToDatabaseFinisher.php:309ReplyDone -
core-ci voted on patch set 4 V +1 09/16/26, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108662
-
Benni Mack voted on patch set 4 V +1 09/16/26, 08:42
-
Wouter Wolters voted on patch set 4 CR +1 V +1 09/16/26, 19:25
-
Benni Mack voted on patch set 4 CR +2 V +2 09/16/26, 19:42
-
Benni Mack merged patch set 5 09/16/26, 19:43
SaveToDatabaseFinisher.php:338