Review main Merged

94986[BUGFIX] Use proper EnvironmentController test transparency generation

Garvin Hicking CR +2 V +2 Easy +2 −2 updated 07/29/26, 14:34

Commit message

As noted in #97975 in depth, transparency information interpretation
in GraphicsMagick and ImageMagick acts a bit differently, and using
a "-background none" parameter allows to prevent applying a white
background.

However, when the parameter "-flatten" is used, GraphicsMagick
interprets this background instruction to actually create
a background, leading to a wrong expectation.

The "-flatten" argument is irrelevant, because the proper "frame"
is already selected, and no flattening is needed. The "[0] in
the generation command already takes care of it:

```
/usr/bin/gm convert -interlace 'None' -auto-orient \
  -background none '+profile' '*' -auto-orient \
  -geometry 300x225! -quality 85 -colorspace 'RGB' \
  'png:/some.png[0]' 'some.webp'
```

The "-flatten" argument was mistakenly copy-pastad into
the test introduced in #97975 and is now removed to properly
act on it. Regular frontend image generation never uses
"-flatten" by default, so having this in a test may lead
people searching for transparency related CSS generation bugs
on a wrong route.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Garvin Hicking uploaded patch set 1 07/29/26, 13:10

  2. Garvin Hicking updated the commit message in patch set 2 07/29/26, 13:17

  3. Sven Liebert voted on patch set 2 CR +1 V +1 07/29/26, 13:19

  4. core-ci voted on patch set 1 V +1 07/29/26, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105603

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 07/29/26, 13:22

  6. core-ci voted on patch set 2 V +1 07/29/26, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105606

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 07/29/26, 14:16

  8. Stefan Bürk merged patch set 3 07/29/26, 14:34