Review 14.3 Merged

94992[BUGFIX] Adjust blinded database connection options

Stefan Bürk CR +2 V +2 Hard +262 −16 updated 07/29/26, 14:52

Commit message

ConnectionDriverMiddlewaresProvider declares its blinded configuration
options for "Connections/Default" with option names that predate the
Doctrine DBAL integration: "database", "socket" and "username". The
rendered "Raw" section contains the connection parameters as resolved
by ConnectionPool, which names them "dbname", "unix_socket" and "user",
so the declared options never match an existing option.

The option names are adjusted to the ones GlobalVariableProvider
already declares for TYPO3_CONF_VARS/DB/Connections/Default.

Both providers share the declaration made for the "Default" connection
with all further configured connections. That handling is moved into a
common trait and applied to the connections of the rendered
configuration array. Options declared for a single connection - for
example by a listener of the ModifyBlindedConfigurationOptionsEvent -
are merged instead of being overwritten, and a removed declaration no
longer emits a warning.

Functional tests are added for the driver middlewares provider and
extended for the global variable provider.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Stefan Bürk commented on patch set 1 07/29/26, 14:15

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/29/26, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105616

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 07/29/26, 14:52

  4. Stefan Bürk merged patch set 2 07/29/26, 14:52