Review 13.4 Merged

94997[BUGFIX] Render nothing in f:image for unavailable files

Stefan Bürk CR +2 V +2 Normal +56 −0 updated 07/29/26, 15:15

Commit message

When a file is flagged as missing by the file indexer, has been
deleted, or resides in an offline storage, it has no public URL.
The image ViewHelper did not take this into account and rendered
an "img" tag with an empty "src" attribute, which is invalid
markup and results in a broken image in the browser.

The same applies when no public URL can be determined at all, for
instance for a file in a non-public storage while no request is
available to build a file dump URL from.

f:image now renders nothing at all in these cases, which is in
line with f:link.file, which already returns an empty string when
the public URL of a file can not be determined.

Additionally, requesting an unavailable file with base64="1" no
longer bubbles up a ResourcePermissionsUnavailableException from
the driver.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Stefan Bürk uploaded patch set 1 07/29/26, 15:08

  2. core-ci voted on patch set 1 V +1 07/29/26, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105622

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 07/29/26, 15:15

  4. Stefan Bürk merged patch set 2 07/29/26, 15:15