Review main Merged

95001[BUGFIX] Resolve file metadata again when the context changed

Benni Mack CR +2 V +2 Normal +160 −3 updated 09/30/26, 21:01

Commit message

The metadata of a file is resolved for the language and workspace
of the current context, but MetaDataAspect and FileReference keep
the resolved record for the lifetime of the object, while the
ResourceFactory keeps the objects themselves for the whole request
without any language in its cache identifier.

Whenever more than one language is rendered within a single process -
a command controller, a cache warmup, frontend sub-requests or an
Extbase query for a specific language - the language that happened to
be active first therefore wins, and every language after that receives
the metadata of that first one.

Both in-object caches are now rebuilt once the language, its fallback
chain or the workspace of the context changed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 912

  1. Benni Mack uploaded patch set 1 07/29/26, 16:26

  2. Benni Mack marked it ready for review 07/29/26, 16:27

  3. core-ci voted on patch set 1 V -1 07/29/26, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105627

  4. Benni Mack rebased onto patch set 2 V -1 07/30/26, 11:30

  5. core-ci voted on patch set 2 V -1 07/30/26, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105686

  6. Benni Mack uploaded patch set 3 V -1 07/30/26, 18:04

  7. core-ci voted on patch set 3 V +1 07/30/26, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105710

  8. Oliver Klee voted on patch set 3 V +1 08/02/26, 08:53

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 08/02/26, 23:20

  10. Georg Ringer voted on patch set 3 CR +1 V +1 09/30/26, 18:48

  11. Benni Mack voted on patch set 3 CR +2 V +2 09/30/26, 21:01

  12. Benni Mack merged patch set 4 09/30/26, 21:01