Review 13.4 Merged

95010[TASK] Raise property-info, adapt ClassSchema tests

Stefan Bürk CR +2 V +2 Normal +59 −17 updated 07/30/26, 08:57

Commit message

symfony/property-info v7.4.15 ships the upstream bugfix "Prevent
PhpDocTypeHelper to wrongly assume keys type". Until then "Type[]" and
"array<Type>" were resolved as a list, implying integer and sequential
keys. PHPDoc does not promise that, only "list<Type>" does, so both
notations now resolve to a plain array keyed by "int|string".

Four Extbase ClassSchema tests asserted the previous, wrong behaviour
and started to fail in the nightly "unit ... max" jobs. They cover the
fixture properties annotated "string[]" and "array<string>"; the
"array<int,string>" property carries an explicit key type and is
unaffected.

The expectations are adapted to the corrected resolution. A
"list<string>" property is added to both dummy models along with
matching test methods, because that notation is the only one still
promising integer keys and therefore pins the distinction the upstream
fix is about, which the existing fixtures did not cover.

The minimum required version is raised to 7.4.15 in the root manifest
and in the extbase manifest, the only two places declaring the
component. Raising the lock alone would not do: the nightly "min" jobs
resolve from the constraint, so with "^7.4.8" they install exactly
7.4.8 and fail the adapted expectations, trading a red "max" job for a
red "min" one. Both variants were verified locally.

Only the collection key type changes. isCollection() still reports a
collection, getBuiltinType() still reports "array", and the collection
value type is still "string". Nothing outside these tests reads the
key type: getCollectionKeyTypes() has no call site in any Classes
directory and isList() is never used, so the data mapper, the property
mapper, validation and file handling are not affected. Controller
action arguments are unaffected as well, since ClassSchema builds
parameter types from native reflection and not from the extractor. The
Extbase functional suite passes unchanged. ObjectStorage properties
already resolved to "int|string" keys before this change, so mixed key
types on collections are nothing new to Extbase.

Backports differ:

* 14.3 declares "^7.4.8" in both manifests, identical to main, and
  uses the same Symfony TypeInfo based ClassSchema. The change applies
  unmodified.
* 13.4 declares "^7.4" in both manifests, so the raise replaces a
  different constraint string. That branch also still uses the legacy
  PropertyInfo Type API, where the same upstream change drops the
  collection key type entirely instead of widening it, so the test
  expectation becomes an empty key type list there.

No branch allows a 6.x line of the component, all three are on
Symfony 7.4, so raising to 7.4.15 needs no further constraint work.

Used command(s):

composer require "symfony/property-info:^7.4.15"
composer require --no-update --working-dir=typo3/sysext/extbase \
    "symfony/property-info:^7.4.15"

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 34

  1. Stefan Bürk uploaded patch set 1 07/30/26, 07:20

  2. core-ci voted on patch set 1 V +1 07/30/26, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105666

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 07/30/26, 08:56

  4. Stefan Bürk merged patch set 2 07/30/26, 08:57