Review main Merged

95011[BUGFIX] Cast debug value to string before translating in Adminpanel

Maike Kiebele CR +2 V +2 Easy +46 −1 updated 08/01/26, 11:14

Commit message

TableKeyValue.fluid.html previously treated any value that was not an integer, float, boolean, or array as a string. This included PHP
resources, which were passed directly as the "key" and "default"
arguments to <f:translate>, resulting in an uncaught
InvalidArgumentValueException.

Explicitly detect resources and render them via the existing raw output path instead of attempting a translation. Cast actual string values to string before passing them to <f:translate>.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • Susi Moog +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Maike Kiebele uploaded patch set 1 07/30/26, 07:37

  2. core-ci voted on patch set 1 V +1 07/30/26, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105667

  3. Benni Mack voted on patch set 1 CR +1 V +1 07/31/26, 08:30

  4. Susi Moog voted on patch set 1 CR +1 V +1 07/31/26, 12:40

  5. Garvin Hicking commented on patch set 1 07/31/26, 15:53

    TableKeyValue.fluid.html:29

    Imo we should use the typeClass = resource case for a distinct one? Otherwise the variable will no longer show up? (From reading only, sorry if I'm wrong)
  6. Stefan Bürk commented on patch set 1 CR +1 V +1 08/01/26, 09:51

    TableKeyValue.fluid.html:29 Reply

    Why ? It would be still displayed with the defaultCase (raw output) and is literally what the commit message explains as intention to avoid that the resource is passed to `f:translate` in the string path - because string is the "default" in the chain above and nothing changed the typeClass for a resource. ``` This included PHP resources, which were passed directly as the "key" and "default" arguments to <f:translate>, resulting in an uncaught InvalidArgumentValueException. Explicitly detect resources and render them via the existing raw output path instead of attempting a translation. Cast actual string values to string before passing them to <f:translate>. ``` That's pretty fine here.
  7. Garvin Hicking commented on patch set 1 CR +2 V +2 08/01/26, 11:13

    TableKeyValue.fluid.html:29 Reply

    Sorry I missed the default case exists and didnt read carefully enough, my bad.
  8. Garvin Hicking commented on patch set 1 08/01/26, 11:14

    TableKeyValue.fluid.html:29 Reply

    Done
  9. Garvin Hicking merged patch set 2 08/01/26, 11:14