95011[BUGFIX] Cast debug value to string before translating in Adminpanel
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Stefan Bürk +1
- Susi Moog +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Stefan Bürk +1
- Susi Moog +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 89
-
Maike Kiebele uploaded patch set 1 07/30/26, 07:37
-
core-ci voted on patch set 1 V +1 07/30/26, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105667
-
Benni Mack voted on patch set 1 CR +1 V +1 07/31/26, 08:30
-
Susi Moog voted on patch set 1 CR +1 V +1 07/31/26, 12:40
-
Garvin Hicking commented on patch set 1 07/31/26, 15:53
-
Stefan Bürk commented on patch set 1 CR +1 V +1 08/01/26, 09:51
TableKeyValue.fluid.html:29ReplyWhy ? It would be still displayed with the defaultCase (raw output) and is literally what the commit message explains as intention to avoid that the resource is passed to `f:translate` in the string path - because string is the "default" in the chain above and nothing changed the typeClass for a resource. ``` This included PHP resources, which were passed directly as the "key" and "default" arguments to <f:translate>, resulting in an uncaught InvalidArgumentValueException. Explicitly detect resources and render them via the existing raw output path instead of attempting a translation. Cast actual string values to string before passing them to <f:translate>. ``` That's pretty fine here. -
Garvin Hicking commented on patch set 1 CR +2 V +2 08/01/26, 11:13
TableKeyValue.fluid.html:29ReplySorry I missed the default case exists and didnt read carefully enough, my bad. -
Garvin Hicking commented on patch set 1 08/01/26, 11:14
TableKeyValue.fluid.html:29ReplyDone -
Garvin Hicking merged patch set 2 08/01/26, 11:14
TableKeyValue.fluid.html:29