Review main Merged

95014[TASK] Declare functional test instance configuration as properties

Benni Mack CR +2 V +2 Normal +37 −28 updated 07/30/26, 10:39

Commit message

Functional test cases shape their test instance through a fixed set of
properties: $coreExtensionsToLoad, $testExtensionsToLoad,
$configurationToUseInTestInstance, $pathsToLinkInTestInstance,
$pathsToProvideInTestInstance, $additionalFoldersToCreate and
$initializeDatabase.

A few test cases assigned these in their own setUp() before calling
parent::setUp() instead of declaring them. That works, but it hides the
instance configuration from static inspection: reading the class
declaration no longer tells which extensions a test case loads. It is
also inconsistent - the vast majority of test cases declare these
properties.

The following test cases are changed to declare their configuration:

* ext:info PageInformationControllerTest
* ext:seo MetaTagTest
* ext:frontend RequestHandlerTest
* ext:frontend ShowImageControllerTest
* ext:core AbstractSchemaBasedTestCase
* ext:core DatetimeLegacyTest

The effective values are unchanged. DatetimeLegacyTest built its
"initCommands" string with implode(), which is not allowed in a property
initializer, so the list is concatenated instead - the resulting SQL
string is byte identical.

AbstractSchemaBasedTestCase is an abstract base, so declaring
$initializeDatabase there covers SchemaMigratorTest and
UuidFieldTypeTest.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 67

  1. Benni Mack uploaded patch set 1 07/30/26, 09:29

  2. core-ci voted on patch set 1 V +1 07/30/26, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105675

  3. Benni Mack marked it ready for review 07/30/26, 09:48

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 07/30/26, 09:54

  5. Stefan Bürk voted on patch set 1 CR +1 V +1 07/30/26, 09:57

  6. Benni Mack voted on patch set 1 CR +2 V +2 07/30/26, 10:39

  7. Benni Mack merged patch set 2 07/30/26, 10:39