95020[BUGFIX] Resolve file metadata translations in every context
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 12
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+35 −6
- typo3/sysext/core/Classes/Resource/MetaDataAspect.php+14 −18
- typo3/sysext/core/Documentation/Changelog/15.0/Important-110333-FileMetadataIsResolvedInEveryContext.rstnew+34 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/MetaDataAspect/WorkspaceDeletedMetaData.csvnew+3 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/MetaDataAspect/WorkspaceDeletedMetaDataSaved.csvnew+5 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/MetaDataAspect/WorkspaceModifiedMetaData.csvnew+3 −0
- typo3/sysext/core/Tests/Functional/Resource/MetaDataAspectTest.php+33 −5
- typo3/sysext/core/Tests/Unit/Resource/MetaDataAspectTest.php+4 −2
- typo3/sysext/frontend/Classes/Aspect/FileMetadataOverlayAspect.phpdeleted+0 −61
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/FileMetadataTranslationScenario.yamlrenamed+0 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/FileMetadataTranslationTest.typoscriptrenamed+0 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/FileMetadataTranslationTest.phprenamed+4 −4
Review log 1217
-
Benni Mack uploaded patch set 1 07/30/26, 12:41
-
core-ci voted on patch set 1 V -1 07/30/26, 12:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105690
-
Benni Mack uploaded patch set 2
V -109/30/26, 21:34 -
Benni Mack marked it ready for review 09/30/26, 21:34
-
core-ci voted on patch set 2 V -1 09/30/26, 21:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109722
-
Benni Mack uploaded patch set 3
V -110/01/26, 08:43 -
core-ci voted on patch set 3 V +1 10/01/26, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109773
-
Benni Mack commented on patch set 4
V +110/01/26, 10:36Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 10/01/26, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109783
-
Oli Bartsch commented on patch set 4 V -1 10/01/26, 12:05
on it....... -
Oli Bartsch uploaded patch set 5
V +110/01/26, 12:19 -
Oli Bartsch commented on patch set 5 10/01/26, 12:21
Reply
Found some workspace regression:. For a delete placeholder, versionOL() returns false, so save() creates a second live sys_file_metadata row. I have fixed this. save() falls back to the raw row and updates live. I also dropped a duplicate test and corrected the RST ordering sentence. -
core-ci voted on patch set 5 V +1 10/01/26, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109789
-
Oli Bartsch voted on patch set 5 CR +1 V +1 10/01/26, 12:32
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 10/02/26, 00:04
-
Benni Mack voted on patch set 5 CR +2 V +2 10/02/26, 13:35
-
Benni Mack merged patch set 6 10/02/26, 13:35