Review main Merged

95021[DOCS] Document purpose and use-cases of PlainDataResolver

Benni Mack CR +2 V +2 Easy +28 −4 updated 08/01/26, 09:11

Commit message

The class documentation only stated that PlainDataResolver "resolves
data constraints" on a plain database level, which left its actual
scope open to interpretation. Most notably it did not mention that
the class deals with the workspace context exclusively, which kept
raising the question whether localization and language fallback
resolving should be integrated here as well.

They should not: language overlays and fallback chains are applied
in a separate, later step by PageRepository->getLanguageOverlay(),
which is orchestrated by GreedyDatabaseBackend for the record API.
Resolving them in PlainDataResolver as well would duplicate that
layer and risk overlaying records twice.

The class docblock now describes the input and output, the order of
the steps applied by get(), the deliberate workspace-only scope and
the known use-cases within the core.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Benni Mack uploaded patch set 1 07/30/26, 12:52

  2. core-ci voted on patch set 1 V +1 07/30/26, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105691

  3. Benni Mack updated the commit message in patch set 2 V +1 07/30/26, 13:04

  4. Benni Mack marked it ready for review 07/30/26, 13:04

  5. Benni Mack updated the commit message in patch set 3 07/30/26, 13:04

  6. core-ci voted on patch set 2 V +1 07/30/26, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105692

  7. core-ci voted on patch set 3 V +1 07/30/26, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105693

  8. Garvin Hicking commented on patch set 3 CR +1 V +1 07/30/26, 13:15

    Maybe we should move this class to EXT:workspace for scoping, and have the old namespace be aliased?
  9. Benni Mack commented on patch set 3 07/30/26, 13:21

    Reply

    the main consumers are RelationHandler and EXT:backend, I don't see it...
  10. Stefan Bürk voted on patch set 3 CR +2 V +2 08/01/26, 09:00

  11. Stefan Bürk merged patch set 4 08/01/26, 09:11