95026[FEATURE] Add named mail profiles
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Josua Vogel +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Josua Vogel +1
- core-ci +1 CI
Issues 2
Files 19
- typo3/sysext/core/Classes/Command/SendEmailCommand.php3+14 −5
- typo3/sysext/core/Classes/Mail/Mailer.php+10 −28
- typo3/sysext/core/Classes/Mail/MailerFactory.phpnew+70 −0
- typo3/sysext/core/Classes/Mail/MailProfileResolver.phpnew+152 −0
- typo3/sysext/core/Classes/Mail/MemorySpool.php+7 −5
- typo3/sysext/core/Classes/Mail/SenderDefaults.phpnew+63 −0
- typo3/sysext/core/Classes/Mail/TransportFactory.php+4 −1
- typo3/sysext/core/Classes/Utility/MailUtility.php+2 −11
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-110337-NamedMailProfiles.rstnew+140 −0
- typo3/sysext/core/Tests/Unit/Command/SendEmailCommandTest.php+44 −9
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/RecordingTransportFixture.phpnew+44 −0
- typo3/sysext/core/Tests/Unit/Mail/MailerFactoryTest.phpnew+144 −0
- typo3/sysext/core/Tests/Unit/Mail/MailProfileResolverTest.phpnew+266 −0
- typo3/sysext/core/Tests/Unit/Mail/SenderDefaultsTest.phpnew+78 −0
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+20 −0
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/GlobalVariableProvider.php+33 −0
- typo3/sysext/lowlevel/Tests/Functional/ConfigurationModuleProvider/GlobalVariableProviderTest.php+44 −0
Review log 2125
-
Benni Mack uploaded patch set 1 07/30/26, 20:12
-
core-ci voted on patch set 1 V +1 07/30/26, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105712
-
Simon Schaufelberger voted on patch set 1 CR +1 08/01/26, 20:22
-
Oliver Klee voted on patch set 1 V +1 08/02/26, 08:52
-
Garvin Hicking commented on patch set 1 09/25/26, 15:02
How would you feel about this be implemented alongside a "mail profiles per site" configuration? It would be cool to define all the mail related things per site. Then we could also set up "dummy" sites that contain specific bulk sending configs that could be used on CLI contexts...? The upside would be to be able to nicely configure this with FormEngine inside the GUI, and not have a "messy" PHP array? Also, this would allow to utilize environment/deployment-specific configurations (of course, also possible with additional.php) -
Garvin Hicking commented on patch set 1 09/25/26, 15:29
Reply
Oh I see, https://review.typo3.org/c/Packages/TYPO3.CMS/+/95027 is what deals with this, I did not notice. (let's set a cross-issue- "Related:" in both?) -
Garvin Hicking commented on patch set 1 09/25/26, 15:31
Reply
... I'd still see benefits in people being able to define sender mail addresses and sender names in the GUI (site settings), and not in a profile? -
Benni Mack uploaded patch set 2
CR +1V +111/13/26, 18:01 -
Benni Mack commented on patch set 2 11/13/26, 18:04
Reply
Related: done. Site selection is in #95027. The profiles stay in settings.php because they contain credentials. -
Benni Mack rebased onto patch set 3 11/14/26, 06:52
-
core-ci voted on patch set 3 V +1 11/14/26, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114418
-
Josua Vogel commented on patch set 3 11/16/26, 08:32
I think the sensible data (password, ... ) should be masked inside configuration overview (lowlevel) like the database credentials -
Benni Mack uploaded patch set 4
V +111/18/26, 20:27 -
core-ci voted on patch set 4 V +1 11/18/26, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114918
-
Benni Mack commented on patch set 4 11/18/26, 21:30
Reply
Done -
Josua Vogel commented on patch set 4 11/19/26, 08:28
SendEmailCommand.php:40This is breaking, when someone extended the SendEmailCommand. I think we should mention this. -
Benni Mack commented on patch set 4 11/19/26, 09:52
SendEmailCommand.php:40Replybut this boils down to "when somebody XCLASSes something, we do not cover this in the BW-compat" -
Josua Vogel commented on patch set 4 CR +1 V +1 11/19/26, 09:57
SendEmailCommand.php:40ReplyAcknowledged -
Fabien Udriot voted on patch set 4 CR +1 11/19/26, 15:50
-
Benni Mack uploaded patch set 5
CR +1V +111/19/26, 17:33 -
core-ci voted on patch set 5 V +1 11/19/26, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115034
-
Garvin Hicking commented on patch set 5 CR +1 V +1 11/20/26, 16:14
This change is ready for review.Works well for me. Also in conjunction with the BeforeMailerSentMessageEvent (which takes priority, as I would expect). -
Josua Vogel voted on patch set 5 CR +1 V +1 11/20/26, 16:42
-
Benni Mack commented on patch set 5 CR +2 V +2 11/20/26, 16:43
thank you! -
Benni Mack merged patch set 6 11/20/26, 16:43