Review main Merged

95031[BUGFIX] Do not render "new element" button on SummaryPage in form editor

Josua Vogel CR +2 V +2 Easy +3 −3 updated 08/01/26, 19:56

Commit message

The "Create new element" placeholder was rendered for all top-level
form elements, including SummaryPage. Since SummaryPage has
_isCompositeFormElement set to false, it cannot contain child elements,
so rendering the button is misleading and non-functional.

The placeholder is now only rendered for composite containers.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Martin Kutschker +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Martin Kutschker +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Josua Vogel uploaded patch set 1 07/31/26, 06:24

  2. Josua Vogel updated the commit message in patch set 2 07/31/26, 06:26

  3. core-ci voted on patch set 1 V +1 07/31/26, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105733

  4. core-ci voted on patch set 2 V +1 07/31/26, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105734

  5. Martin Kutschker voted on patch set 2 CR +1 V +1 07/31/26, 07:55

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 07/31/26, 08:09

  7. Sven Liebert voted on patch set 2 CR +1 V +1 07/31/26, 08:13

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 08/01/26, 19:30

  9. Stefan Bürk merged patch set 3 08/01/26, 19:56