Review 14.3 Merged

95033[BUGFIX] Point ActiveRelation to the foreign table for MM relations

Benni Mack CR +2 V +2 Normal +65 −10 updated 07/31/26, 07:24

Commit message

ActiveRelation exposed the intermediate "MM" table via toTable()
instead of the table the relation actually points to, and the
foreign table was dropped entirely. This is inconsistent with
PassiveRelation, which matches on the foreign table, and with the
documented meaning of the class.

toTable() now returns the foreign table for MM relations as well.
The intermediate table is kept in the new manyToManyTable(), with
isManyToMany() as a convenience, so no information is lost.

PassiveRelation additionally receives the missing flexPointer()
getter. The property was built and cached but unreachable, which
the PHPStan baseline documented as "never read, only written".

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Benni Mack commented on patch set 1 07/31/26, 07:03

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/31/26, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105736

  3. Benni Mack voted on patch set 1 CR +2 V +2 07/31/26, 07:24

  4. Benni Mack merged patch set 2 07/31/26, 07:24