Review main Merged

95040[TASK] Deprecate AssetCollector media handling

Benni Mack CR +2 V +2 Hard +396 −69 updated 08/02/26, 20:40

Commit message

AssetCollector->addMedia(), getMedia(), hasMedia() and removeMedia()
are deprecated and will be removed in v16.

Unlike JavaScript and stylesheet assets, collected media never
contributed anything to the rendered output. The registry is a
leftover of $TSFE->imagesOnPage, which was moved to the
AssetCollector in v10.3 and only ever served the "Images on this
page" section of the admin panel.

Having every image renderer report into a central registry only ever
covered the code paths that remembered to call addMedia().
AfterFileProcessingEvent is dispatched for every processed file and
is a complete source for the same information, so the admin panel
now collects the data through a PSR-14 listener instead.

As a side effect the panel reports correct file sizes for images in
remote storages - the previous implementation reconstructed a local
path from the public URL and reported 0 bytes whenever that path did
not exist - and additionally shows the image dimensions.

Core does not populate the registry anymore: ImageService and the
IMAGE content object no longer call addMedia().

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 810

  1. Benni Mack uploaded patch set 1 07/31/26, 19:23

  2. core-ci voted on patch set 1 V +1 07/31/26, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105759

  3. Benni Mack uploaded patch set 2 V +1 08/01/26, 06:13

  4. core-ci voted on patch set 2 V +1 08/01/26, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105779

  5. Benni Mack marked it ready for review 08/01/26, 10:08

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 08/01/26, 12:30

  7. Oliver Klee voted on patch set 2 V +1 08/02/26, 08:52

  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 08/02/26, 08:56

  9. Stefan Bürk voted on patch set 2 CR +2 V +2 08/02/26, 20:40

  10. Stefan Bürk merged patch set 3 08/02/26, 20:40