Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Stale

95043[WIP][BUGFIX] Hide connected mode for free mode translation sources

Eric Harrer CR 0 V 0 Hard +258 −4 updated 08/28/26, 21:48

Commit message

The translation wizard offered both "Translate" and "Copy" even when the
selected source records were free mode records of a non default language.

DataHandler->localize() only assigns a translation origin pointer when
localizing a default language record. When localizing from another
language the origin pointer of the source record is reused, so a free
mode source can only ever produce a free mode target. Choosing the
connected mode therefore created exactly the structure expected from
"Copy" and had no effect at all.

The wizard now evaluates the records it is about to localize. The
connected mode is only offered if at least one of them provides a
default language origin, which is the case for default language records
and for connected translations. To make this work for pages, the mode
step passes the selected content elements to the endpoint. With "Copy"
as the only remaining mode the wizard skips the mode step, following
the behavior introduced with #95909.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/43/95043/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/43/95043/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 2

Files 5

Review log 23

  1. Eric Harrer uploaded patch set 1 07/31/26, 22:53

  2. core-ci voted on patch set 1 V +1 07/31/26, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105762

  3. Eric Harrer marked it work in progress 08/28/26, 21:48