Review 13.4 Merged

95048[DOCS] Document purpose and use-cases of PlainDataResolver

Stefan Bürk CR +2 V +2 Easy +28 −4 updated 08/01/26, 09:11

Commit message

The class documentation only stated that PlainDataResolver "resolves
data constraints" on a plain database level, which left its actual
scope open to interpretation. Most notably it did not mention that
the class deals with the workspace context exclusively, which kept
raising the question whether localization and language fallback
resolving should be integrated here as well.

They should not: language overlays and fallback chains are applied
in a separate, later step by PageRepository->getLanguageOverlay(),
which is orchestrated by GreedyDatabaseBackend for the record API.
Resolving them in PlainDataResolver as well would duplicate that
layer and risk overlaying records twice.

The class docblock now describes the input and output, the order of
the steps applied by get(), the deliberate workspace-only scope and
the known use-cases within the core.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 08/01/26, 09:00

    Cherry Picked from branch 14.3.
  2. core-ci voted on patch set 1 V +1 08/01/26, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105786

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 08/01/26, 09:11

  4. Stefan Bürk merged patch set 2 08/01/26, 09:11