Review main Merged

95049[BUGFIX] Respect disabled and overridden User Settings fields

Benni Mack CR +2 V +2 Hard +565 −0 updated 08/04/26, 09:28

Commit message

Since the FormEngine-based rendering of the User Settings module,
two user TSconfig options were no longer evaluated when rendering
the form:

* Fields disabled via `setup.fields.<fieldName>.disabled = 1`
  were still displayed. Only the save path filtered them, leading
  to visible fields whose submitted values were silently
  discarded.
* Fields enforced via `setup.override.<fieldName>` were rendered
  as regular editable fields, although any submitted change is
  overridden again on every request. The former rendering marked
  such fields as disabled.

Two new form data providers now restore the previous behavior:
UserSettingsDisabledFields removes disabled fields from the
compiled showitem of the be_users_settings pseudo-table -
including the password -> password2 chaining known from the save
path - and UserSettingsOverrideFields sets overridden columns to
readOnly, so FormEngine renders them as disabled fields again.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 56

  1. Benni Mack uploaded patch set 1 08/01/26, 10:07

  2. core-ci voted on patch set 1 V +1 08/01/26, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105787

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 08/01/26, 12:27

  4. Oliver Klee voted on patch set 1 V +1 08/02/26, 08:52

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 08/04/26, 07:19

  6. Garvin Hicking merged patch set 2 08/04/26, 09:28