Review main Merged

95050[TASK] Raise symfony/property-info to 8.1.2

Stefan Bürk CR +2 V +2 Easy +3 −3 updated 08/01/26, 11:18

Commit message

The four Extbase ClassSchema tests adapted with #110325 assert the
corrected collection key type resolution of symfony/property-info,
introduced upstream with v7.4.15 by the fix "Prevent PhpDocTypeHelper
to wrongly assume keys type". Since these expectations only hold with
that version, the constraint had to be raised in the root manifest and
in the Extbase manifest, the only two declaring the component: the
nightly "min" jobs resolve from the constraint and not from the lock
file.

The Symfony 8.1 upgrade replaced all symfony constraints with "~8.1.0"
and thereby dropped that minimum again. For this component the 8.1 line
publishes v8.1.0 and v8.1.2 only, and just v8.1.2 carries the merged up
key type fix. The "max" jobs install v8.1.2 and stay green, while the
"min" jobs install v8.1.0 and fail all four test methods with one
instead of two collection key types, as in nightly pipeline 105764 from
2026-08-01.

The constraint is therefore raised to "~8.1.2" in both manifests. The
lock file already resolves v8.1.2, so only its content hash changes.
Verified with a lowest resolution install of the raised constraint: the
ClassSchema property unit tests pass.

main is the only affected branch. 14.3 and 13.4 stay on the 7.4 line of
the component and already declare "^7.4.15".

Used command(s):

./Build/Scripts/runTests.sh -s composer -- \
    require "symfony/property-info:~8.1.2"
./Build/Scripts/runTests.sh -s composer -- \
    require --no-update --working-dir=typo3/sysext/extbase \
    "symfony/property-info:~8.1.2"
./Build/Scripts/runTests.sh -s composerValidate

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 46

  1. Stefan Bürk uploaded patch set 1 08/01/26, 10:53

  2. Benni Mack voted on patch set 1 CR +1 V +1 08/01/26, 11:00

  3. core-ci voted on patch set 1 V +1 08/01/26, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105788

  4. core-ci commented on patch set 1 08/01/26, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105789

  5. Stefan Bürk commented on patch set 1 CR +2 V +2 08/01/26, 11:18

    Merging this slightly bending the rules; it's a defacto no-brainer, lock file already had the version and it restores a original fix reverted.
  6. Stefan Bürk merged patch set 2 08/01/26, 11:18