Review 13.4 Merged

95053[BUGFIX] Isolate update check from download queue

Stefan Bürk CR +2 V +2 Hard +420 −1 updated 08/01/26, 12:24

Commit message

`ListUtility::getUpdateableVersion()` reports whether a newer
version of an installed extension is available. It walks the
update candidates of an extension key, newest first, and returns
the first one whose dependencies resolve.

Determining that is a query, but the dependency check marks
dependent extensions for download, update and installation as a
side effect. Those queues are shared, so each probed candidate
leaves its dependencies behind - including the candidates which
have been rejected, and those of all extensions listed before.

Extension keys maintained for two core versions in parallel turn
this into a fatal condition. Their major lines depend on
different major versions of a shared base extension, so probing
them queues that base extension twice in conflicting versions and
`DownloadQueue::addExtensionToQueue()` throws:

  deepl_base was requested to be downloaded in different versions
  (2.0.2 and 1.0.3).

The exception aborts the whole listing, which renders the
extension list module and feeds the extension status report of
EXT:reports. Both break entirely, although the request is not
going to download anything at all.

Update candidates are now probed with empty queues, restoring the
state of an enclosing dependency resolve run afterwards. The
listing therefore no longer depends on side effects of the
dependency check.

A functional test covers the constellation of two extensions
sharing a base extension, which is required in conflicting major
versions.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 4

Files 6

Review log 34

  1. Stefan Bürk uploaded patch set 1 08/01/26, 11:54

  2. core-ci voted on patch set 1 V +1 08/01/26, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105794

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 08/01/26, 12:24

  4. Stefan Bürk merged patch set 2 08/01/26, 12:24