Review 14.3 Merged

95069[TASK] Cache resolved site configuration data in core cache

Benni Mack CR +2 V +2 Normal +192 −24 updated 09/01/26, 19:16

Commit message

SiteConfiguration now caches all data needed to create Site
entity objects in the "core" cache along with the raw site
configuration: the configuration enriched with route enhancers
provided by site sets, composed site settings, invalid set
information, as well as the contents of the optional per-site
files csp.yaml, setup.typoscript, constants.typoscript and
page.tsconfig. Previously, this data was recomputed and re-read
from the file system on every request.

The Site entity objects themselves are still created at runtime
once per request, since their constructor evaluates base variant
expressions, which continue to work per request and environment.

The prepared data is stored within the existing single
"sites-configuration" cache entry to keep the raw configuration
and the resolved data in sync at all times regarding invalidation.

As a side effect, changes applied directly to csp.yaml,
setup.typoscript, constants.typoscript or page.tsconfig of a site
configuration folder now require flushing all caches to become
active - as was already the case for config.yaml and settings.yaml.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benni Mack uploaded patch set 1 08/03/26, 05:14

  2. core-ci voted on patch set 1 V +1 08/03/26, 05:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105868

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 09/01/26, 19:16

  4. Stefan Bürk merged patch set 2 09/01/26, 19:16