Review main Merged Breaking

95073[!!!][TASK] Remove FAL fallback storage (uid 0)

Benni Mack CR +2 V +2 Expert +929 −380 updated 10/16/26, 21:55

Commit message

The virtual "fallback storage" with uid 0, which mounted the whole
public web directory as an implicitly public, browsable and writable
storage, is removed. It was introduced together with FAL in TYPO3 6.0
as a compatibility bridge for pre-FAL file references and has been the
root cause of a series of security issues, contained only by more than
a dozen scattered isFallbackStorage() guard checks, since backend
permission evaluation never applied to this storage.

Extension resources ("EXT:" paths) and public files outside all file
storages are already processed as system resources without FAL
persistence. Plain paths within a configured storage keep resolving
via StorageRepository::findBestMatchingStorageByLocalPath(), folder
links without a storage are matched to the storage containing the
path, and links to "EXT:" resources resolve to their published URL.
Soft references keep the identifier of such resources, so exports stay
valid on other installations.

An upgrade wizard migrates sys_file records with storage 0 into the
best-matching storage, merges records duplicating already indexed
files, flags records outside all storages as missing, and removes
processed file records of the fallback storage, which are regenerated
on demand. Records already flagged as missing are moved as well. The
Install Tool no longer creates or checks typo3temp/assets/_processed_/.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 64

Show 44 more files

Review log 1827

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 08/03/26, 08:57

  2. core-ci voted on patch set 1 V -1 08/03/26, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105875

  1. Benni Mack uploaded patch set 2 V -1 09/23/26, 12:31

  2. core-ci voted on patch set 2 V +1 09/23/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109054

  3. Benni Mack uploaded patch set 3 V +1 09/23/26, 16:07

  4. core-ci voted on patch set 3 V -1 09/23/26, 16:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109086

  5. Benni Mack rebased onto patch set 4 V -1 10/09/26, 10:34

  6. core-ci voted on patch set 4 V -1 10/09/26, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110585

  7. Benni Mack uploaded patch set 5 V -1 10/15/26, 15:52

  8. core-ci voted on patch set 5 V +1 10/15/26, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111220

  9. Benni Mack uploaded patch set 6 V +1 10/15/26, 16:49

  10. core-ci voted on patch set 6 V +1 10/15/26, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111241

  11. Benni Mack uploaded patch set 7 V +1 10/15/26, 17:04

  12. Benni Mack marked it ready for review 10/15/26, 17:07

  13. core-ci voted on patch set 7 V +1 10/15/26, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111249

  14. Wouter Wolters commented on patch set 7 10/15/26, 18:05

    LegacyLinkNotationConverter.php:221

    is using PackageUtility::isExtensionPath($fileIdentifier, true) an option? There are more usages of this in this change.
  15. Benni Mack uploaded patch set 8 V +1 10/15/26, 19:27

  16. Benni Mack commented on patch set 8 10/15/26, 19:27

    LegacyLinkNotationConverter.php:221 Reply

    thanks, fixed this one
  17. core-ci voted on patch set 8 V +1 10/15/26, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111261

  18. Benni Mack uploaded patch set 9 V +1 10/16/26, 14:23

  19. core-ci voted on patch set 9 V +1 10/16/26, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111368

  20. Benjamin Kott voted on patch set 9 CR +1 V +1 10/16/26, 14:57

  21. Georg Ringer voted on patch set 9 CR +1 V +1 10/16/26, 17:59

  22. Benni Mack voted on patch set 9 CR +2 V +2 10/16/26, 20:04

  23. Benni Mack merged patch set 10 10/16/26, 20:04

  24. Markus Klein commented on patch set 9 10/16/26, 20:28

    FallbackStorageMigration.php:192

    are we still using connection::param* ? There is the DBAL native definition for this actually.
  25. Benni Mack commented on patch set 10 10/16/26, 21:55

    FallbackStorageMigration.php:192 Reply

    yup. we never defined something else AFAIK, and Connection was the most stable part until now.