95096[TASK] Stop assuming the classic layout in functional tests
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 62
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListCopyToClipboard.php+4 −2
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTableCopyToClipboard.php+4 −2
- typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArgumentsCopyToClipboard.php+4 −2
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/BitmapIconProviderTest.php2+2 −1
- typo3/sysext/core/Tests/Functional/Mail/TemplatedEmailFactoryTest.php+21 −20
- typo3/sysext/core/Tests/Functional/Package/Event/PackageInitializationEventTest.php+3 −1
- typo3/sysext/core/Tests/Functional/Page/AssetRendererTest.php2+28 −10
- typo3/sysext/core/Tests/Functional/Page/ImportMapTest.php2+24 −11
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+3 −1
- typo3/sysext/core/Tests/Functional/Resource/Driver/LocalDriverTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Resource/Service/ResourceConsistencyServiceTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Resource/DefaultUploadFolderResolverTest.php+9 −8
- typo3/sysext/core/Tests/Functional/Resource/RelativeCssPathFixerTest.php+5 −3
- typo3/sysext/core/Tests/Functional/Resource/ResourceFactoryTest.php+9 −5
- typo3/sysext/core/Tests/Functional/Resource/StorageRepositoryTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Service/Archive/ZipServiceTest.php+13 −12
- typo3/sysext/core/Tests/Functional/Site/Set/YamlSetDefinitionProviderTest.php+3 −2
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php+4 −3
Show 42 more files
- typo3/sysext/core/Tests/Functional/Utility/File/ExtendedFileUtilityTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Utility/GeneralUtilityTest.php+4 −1
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconViewHelperTest.php2+10 −8
- typo3/sysext/extbase/Tests/Functional/Configuration/BackendConfigurationManagerTest.php+2 −1
- typo3/sysext/fluid/Tests/Functional/Core/Component/ComponentsTest.php+13 −12
- typo3/sysext/fluid/Tests/Functional/Service/TemplateFinderTest.php+13 −12
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/PageRendererViewHelperTest.php+4 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Image/SrcsetViewHelperTest.php+2 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ImageViewHelperTest.php+3 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ResourceViewHelperTest.php2+35 −18
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageConvertGMViewHelperTest.php+2 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageConvertIMViewHelperTest.php+2 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+4 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/SvgImageViewHelperTest.php2+23 −2
- typo3/sysext/fluid/Tests/Functional/TemplateAnalyzerTest.php+12 −4
- typo3/sysext/form/Tests/Functional/Core/ExtendedFileUtilityTest.php+2 −1
- typo3/sysext/form/Tests/Functional/Mvc/Property/TypeConverter/MultipleFileUploadTest.php+4 −3
- typo3/sysext/form/Tests/Functional/RequestHandling/RequestHandlingTest.php+3 −2
- typo3/sysext/frontend/Tests/Functional/Aspect/FileMetadataOverlayAspectTest.php+3 −3
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+3 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/FluidTemplateContentObjectTest.php+13 −12
- typo3/sysext/frontend/Tests/Functional/ContentObject/PageViewContentObjectTest.php+7 −6
- typo3/sysext/frontend/Tests/Functional/Rendering/AbsoluteUriPrefixRenderingTest.php+8 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/ScriptAndLinkTagRenderingTest.php+17 −15
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php2+8 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+2 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecords.php+29 −25
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecordsWithSoftRefs.php+21 −17
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportRecords.php+9 −5
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportTable.php+12 −9
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecords.php+15 −12
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdate.php+12 −8
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdateWithDiff.php+32 −28
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithDiff.php+32 −28
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithSoftRefs.php+9 −6
- typo3/sysext/impexp/Tests/Functional/ImportTest.php+9 −0
- typo3/sysext/install/Tests/Functional/Command/PasswordSetCommandTest.php+6 −5
- typo3/sysext/install/Tests/Functional/Service/Typo3tempFileServiceTest.php+2 −1
- typo3/sysext/lowlevel/Tests/Functional/Clean/CleanUpLocalProcessedFilesTest.php+3 −2
- typo3/sysext/lowlevel/Tests/Functional/Localization/LabelFinderTest.php+13 −8
- typo3/sysext/rte_ckeditor/Tests/Functional/Form/Element/RichTextElementTest.php+15 −4
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapXslTest.php+15 −6
Review log 1922
-
Benni Mack uploaded patch set 1 08/04/26, 07:57
-
core-ci voted on patch set 1 V +1 08/04/26, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105928
-
Benni Mack marked it ready for review 08/04/26, 08:08
-
Oliver Klee voted on patch set 1 V +1 08/04/26, 08:20
-
Georg Ringer voted on patch set 1 CR +1 V +1 08/04/26, 09:02
-
Andreas Kienast commented on patch set 1 08/04/26, 10:11
AssetRendererTest.php:245`(string)` cast is not needed as `$markup` is already a string.ImportMapTest.php:106Would it make sense to store the result of `this->assetPath(...)` in a variable instead of resolving it repetitively?IconViewHelperTest.php:99Do we really need the method wrapper?SvgImageViewHelperTest.php:534`(string)` cast is not neededResourceViewHelperTest.php:186`(string)` cast is not neededUriPrefixRenderingTest.php:73Low-grade nit-pick: this condition is faster than `str_starts_with(...)` -
Simon Schaufelberger voted on patch set 1 CR +1 V +1 08/04/26, 10:11
-
Wouter Wolters voted on patch set 1 CR +1 V +1 08/04/26, 18:53
-
Stefan Bürk voted on patch set 1 CR +1 V +1 08/06/26, 14:21
-
Benni Mack uploaded patch set 2
CR +1V +108/06/26, 16:22 -
core-ci voted on patch set 2 V +1 08/06/26, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106005
-
Wouter Wolters voted on patch set 2 CR +1 V +1 08/06/26, 16:40
-
Georg Ringer voted on patch set 2 CR +1 V +1 08/06/26, 18:23
-
Oliver Klee voted on patch set 2 V +1 08/06/26, 21:38
-
Benni Mack uploaded patch set 3
CR +1V +108/08/26, 14:30 -
Benni Mack marked it ready for review 08/08/26, 14:30
-
core-ci voted on patch set 3 V +1 08/08/26, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106184
-
Benni Mack commented on patch set 3 08/08/26, 14:55
BitmapIconProviderTest.php:77ReplyDoneAssetRendererTest.php:245ReplyDoneImportMapTest.php:106ReplyDoneIconViewHelperTest.php:99ReplyDoneSvgImageViewHelperTest.php:534ReplyDoneResourceViewHelperTest.php:186ReplyDoneUriPrefixRenderingTest.php:73ReplyDone -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 08/09/26, 10:44
-
Oliver Klee voted on patch set 3 V +1 08/09/26, 12:45
-
Stefan Bürk voted on patch set 3 CR +2 V +2 08/09/26, 16:49
-
Stefan Bürk merged patch set 4 08/09/26, 16:49
BitmapIconProviderTest.php:77