Review main Merged

95098[TASK] Run the end-to-end tests in classic mode as well

Benni Mack CR +2 V +2 Hard +248 −11 updated 09/01/26, 07:36

Commit message

The Playwright suite only ever ran against a composer installation, so
classic mode has had no end-to-end coverage since the codeception
classic pipeline was dropped with #109759. TYPO3 ships both
installation modes, and the argument for covering both applies here as
much as it does to functional tests.

The specs stay as they are, only the instance they run against
differs. A sweep of Build/tests/playwright found exactly two places
that assumed a composer instance: the helper secret, which already
honoured PLAYWRIGHT_HELPER_SECRET_FILE, and an upload path, which now
reads PLAYWRIGHT_DOCUMENT_ROOT. Both are passed in by runTests.sh, so
the same "e2e" project runs against either instance.

Build/Scripts/setupAcceptanceClassic.sh builds the classic instance in
typo3temp/var/tests/playwright-classic. It symlinks typo3/ and vendor/
from the core checkout, which is itself a classic installation and
therefore defines no TYPO3_COMPOSER_MODE, and drives the command line
through typo3/sysext/core/bin/typo3 with TYPO3_PATH_ROOT and
TYPO3_PATH_APP, the same way functional tests do.

Three things a classic instance needs that a composer one does not:

* The shipped root .htaccess. /typo3/ is a real directory in a classic
  document root, so without the rewrite rule the web server serves the
  directory instead of routing to the entry point and the backend is
  unreachable.
* PackageStates.php written before `typo3 setup`, which cannot boot
  without one, and again afterwards, because setup rewrites it from
  the system extensions it knows and drops the extensions below
  typo3conf/ext. `extension:activate` cannot put them back: it only
  knows packages that are already registered, and registering them
  means a package scan that only runs when there is no PackageStates
  at all.
* The two support extensions must declare an extension version and the
  "providesPackages" definition in their composer manifest, since
  ext_emconf.php is no longer evaluated as a fallback, and their
  namespaces need an autoload-dev entry so classic mode can load them.

Mode selection reuses -M rather than adding e2e-classic suites. Left
unset it resolves to what each suite always did, so no existing
invocation changes meaning.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 913

  1. Benni Mack uploaded patch set 1 08/04/26, 08:47

  2. core-ci voted on patch set 1 V -1 08/04/26, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105931

  3. Benni Mack rebased onto patch set 2 V -1 08/10/26, 07:52

  4. core-ci voted on patch set 2 V -1 08/10/26, 07:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106257

  5. Benni Mack rebased onto patch set 3 V -1 08/10/26, 21:23

  6. core-ci voted on patch set 3 V -1 08/10/26, 21:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106331

  7. Benni Mack commented on patch set 4 V -1 08/11/26, 05:44

    Published edit on patch set 3.
  8. core-ci voted on patch set 4 V +1 08/11/26, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106394

  9. Benni Mack marked it ready for review 08/11/26, 05:56

  10. Oliver Klee voted on patch set 4 V +1 08/11/26, 07:45

  11. Wouter Wolters voted on patch set 4 CR +1 V +1 08/31/26, 21:03

  12. Georg Ringer voted on patch set 4 CR +2 V +2 09/01/26, 07:36

  13. Georg Ringer merged patch set 5 09/01/26, 07:36