Review main Merged

95104[TASK] Remove unused variable in ext:install AuthenticationService

Oliver Hader CR +2 V +2 Easy +0 −1 updated 08/05/26, 11:23

Commit message

Since #109845, the variable `$formValues` is not used anymore and can be
removed from ext:install `AuthenticationService::sendLoginFailedMail`.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oliver Hader uploaded patch set 1 08/04/26, 12:24

  2. Oliver Klee updated the commit message in patch set 2 08/04/26, 12:32

  3. Oliver Klee voted on patch set 2 CR +1 08/04/26, 12:32

  4. core-ci voted on patch set 1 V +1 08/04/26, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105944

  5. core-ci voted on patch set 2 V +1 08/04/26, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105945

  6. Oliver Klee voted on patch set 2 V +1 08/04/26, 12:44

  7. Wouter Wolters voted on patch set 2 CR +1 V +1 08/04/26, 19:43

  8. Georg Ringer voted on patch set 2 CR +1 V +1 08/05/26, 07:55

  9. Oliver Hader voted on patch set 2 CR +2 V +2 08/05/26, 11:23

  10. Oliver Hader merged patch set 3 08/05/26, 11:23