95106[TASK] Remove unused PHP imports
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/backend/Classes/Controller/Event/ModifyNewRecordCreationLinksEvent.php+0 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaLanguage.php+0 −1
- typo3/sysext/backend/Classes/Middleware/JavaScriptLabelImportMapEntryResolver.php+0 −1
- typo3/sysext/backend/Classes/Routing/PreviewUriBuilder.php+0 −1
- typo3/sysext/beuser/Classes/Service/UserInformationService.php+0 −1
- typo3/sysext/core/Classes/Schema/SchemaInterface.php+0 −2
- typo3/sysext/core/Classes/Site/SiteSettingsFactory.php+0 −1
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+0 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/AbstractActionTestCase.php+0 −1
- typo3/sysext/core/Tests/Functional/Localization/LanguageServiceTest.php+0 −1
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+0 −1
- typo3/sysext/filelist/Classes/Controller/FileListController.php+0 −1
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/FormDefinitionArrayConverter.php+0 −1
- typo3/sysext/tstemplate/Classes/Controller/TemplateRecordsOverviewController.php+0 −1
Review log 1011
-
Wouter Wolters uploaded patch set 1 08/04/26, 20:43
-
core-ci voted on patch set 1 V +1 08/04/26, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105949
-
Simon Schaufelberger commented on patch set 1 08/04/26, 21:25
Isn't there a phpcsfixer rule for that? -
Wouter Wolters commented on patch set 1 08/04/26, 21:26
Reply
Yes there is but that leaves these behind somehow. Also when running a clean CGL. -
Simon Schaufelberger commented on patch set 1 08/04/26, 21:33
Reply
does that mean that the rule is buggy? it would be really interesting what causes the rule not to find these unused statements. -
Nikita Hovratov commented on patch set 1 08/04/26, 22:09
Reply
@simonschaufi+typo3@gmail.com Comments most likely. Maybe they can't be distinguished from real phpdocs. -
Oliver Klee voted on patch set 1 CR +1 V +1 08/05/26, 06:48
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 08/05/26, 09:17
-
Simon Schaufelberger commented on patch set 1 08/05/26, 09:57
Reply
Created a bug report: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/9764 -
Georg Ringer voted on patch set 1 CR +2 V +2 08/05/26, 12:25
-
Georg Ringer merged patch set 2 08/05/26, 12:25