Review main Merged

95106[TASK] Remove unused PHP imports

Wouter Wolters CR +2 V +2 Easy +0 −15 updated 08/05/26, 12:25

Commit message

Removes 15 obsolete use statements across Core
and system extensions.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1011

  1. Wouter Wolters uploaded patch set 1 08/04/26, 20:43

  2. core-ci voted on patch set 1 V +1 08/04/26, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105949

  3. Simon Schaufelberger commented on patch set 1 08/04/26, 21:25

    Isn't there a phpcsfixer rule for that?
  4. Wouter Wolters commented on patch set 1 08/04/26, 21:26

    Reply

    Yes there is but that leaves these behind somehow. Also when running a clean CGL.
  5. Simon Schaufelberger commented on patch set 1 08/04/26, 21:33

    Reply

    does that mean that the rule is buggy? it would be really interesting what causes the rule not to find these unused statements.
  6. Nikita Hovratov commented on patch set 1 08/04/26, 22:09

    Reply

    @simonschaufi+typo3@gmail.com Comments most likely. Maybe they can't be distinguished from real phpdocs.
  7. Oliver Klee voted on patch set 1 CR +1 V +1 08/05/26, 06:48

  8. Simon Schaufelberger voted on patch set 1 CR +1 V +1 08/05/26, 09:17

  9. Simon Schaufelberger commented on patch set 1 08/05/26, 09:57

  10. Georg Ringer voted on patch set 1 CR +2 V +2 08/05/26, 12:25

  11. Georg Ringer merged patch set 2 08/05/26, 12:25