Review main Merged

95108[BUGFIX] Do not split paragraphs at inner linebreaks

Benjamin Kott CR +2 V +2 Normal +52 −1 updated 08/06/26, 20:13

Commit message

RteHtmlParser::setDivTags() divided the content going from the database
into the rich text editor at every line break, and wrapped each
resulting line into a paragraph of its own. A line break inside a <p>
element is insignificant whitespace rather than a line separator, so the
element was cut in half and both halves were wrapped again, producing
nested and empty paragraphs. CKEditor resolved that nesting into further
empty paragraphs, which were then persisted on the next save.

Content is now divided into lines only at line breaks located between
elements, leaving <p> and <div> elements intact.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Moritz Ngo +1
    • Andreas Kienast +1
    • Joschua Ngo +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Moritz Ngo +1
    • Andreas Kienast +1
    • Joschua Ngo +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Benjamin Kott uploaded patch set 1 08/05/26, 03:25

  2. core-ci voted on patch set 1 V +1 08/05/26, 03:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105955

  3. Georg Ringer voted on patch set 1 CR +1 V +1 08/05/26, 08:01

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 08/06/26, 07:06

  5. Moritz Ngo voted on patch set 1 CR +1 V +1 08/06/26, 19:01

  6. Joschua Ngo voted on patch set 1 CR +1 V +1 08/06/26, 19:01

  7. Benjamin Kott voted on patch set 1 CR +2 V +2 08/06/26, 19:26

  8. Benjamin Kott merged patch set 2 08/06/26, 20:13