Review main Merged

95110[BUGFIX] Allow extbase files in SrcsetViewHelper

Albrecht Köhnlein CR +2 V +2 Normal +74 −1 updated 08/08/26, 11:21

Commit message

The view helper `<f:image.srcset>` should be usable similar to
`<f:image>`. This requires allowing Extbase File and FileReference
objects, which are wrappers for the corresponding core objects.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Simon Praetorius +1
    • André Buchmann +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Simon Praetorius +1
    • André Buchmann +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1116

  1. Albrecht Köhnlein uploaded patch set 1 08/05/26, 09:31

  2. Albrecht Köhnlein marked it work in progress 08/05/26, 09:32

  3. core-ci voted on patch set 1 V -1 08/05/26, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105970

  4. Albrecht Köhnlein uploaded patch set 2 V -1 08/06/26, 18:36

  5. core-ci voted on patch set 2 V +1 08/06/26, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106014

  6. Albrecht Köhnlein uploaded patch set 3 V +1 08/06/26, 19:23

  7. Albrecht Köhnlein marked it ready for review 08/06/26, 19:23

  8. core-ci voted on patch set 3 V +1 08/06/26, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106024

  9. Albrecht Köhnlein uploaded patch set 4 V +1 08/06/26, 20:02

  10. Albrecht Köhnlein updated the commit message in patch set 5 08/06/26, 20:04

  11. core-ci voted on patch set 4 V +1 08/06/26, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106042

  12. core-ci voted on patch set 5 V +1 08/06/26, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106043

  13. Simon Praetorius voted on patch set 5 CR +1 V +1 08/06/26, 20:19

  14. André Buchmann voted on patch set 5 CR +1 V +1 08/06/26, 20:34

  15. Garvin Hicking voted on patch set 5 CR +2 V +2 08/08/26, 10:59

  16. Garvin Hicking merged patch set 6 08/08/26, 11:21